Closed
Bug 66354
Opened 24 years ago
Closed 23 years ago
Pull-down menu text not visible after selecting an option
Categories
(Core :: DOM: Editor, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: shrir, Assigned: hewitt)
Details
(Whiteboard: FIX IN HAND)
Attachments
(3 files)
5.38 KB,
patch
|
Details | Diff | Splinter Review | |
1.67 KB,
patch
|
Details | Diff | Splinter Review | |
12.56 KB,
patch
|
Details | Diff | Splinter Review |
See on al ltrunk builds (20010123) Steps : 1 Launch Composer 2 On the Composition Toolbar, click on the 'Image' button 3 Observe the 'Image Properties' window open up 4 Click on the 'More Properties' button 5 In the pane titled 'Aligh text to image, click and select any option 6 Observe that the text color of the selection option does not change to white and is black and is not visible under the blue background(with default color settings)
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.8
Comment 4•24 years ago
|
||
Comment 5•24 years ago
|
||
Comment 6•24 years ago
|
||
Resetting milestone to 0.8 since fix is ready. Beppe reviewed the slight changes I made to the image files to make the align states more visible when selected. Kathy and Simon: Can I please get reviews.
Whiteboard: FIX IN HAND
Target Milestone: mozilla0.9.1 → mozilla0.8
Comment 7•24 years ago
|
||
Have the Mac classic skin changes been tested?
Comment 8•24 years ago
|
||
The patches in this bug and bug 66417 contain some of the same changes. Which am I to reveiw?
Comment 9•24 years ago
|
||
Both, please! Since I already requested review for 66417 at the same time, I didn't want to try to disect the newer diff -- thought it might interfere with applying the patch. No to question about checking on Mac. Is Kathy still out? Do you have any time to test the patch?
Comment 10•24 years ago
|
||
I meant which changes should I review for which bug? In general, it's best to keep patches discrete. sr=sfraser
Comment 11•24 years ago
|
||
r=blake
Comment 12•24 years ago
|
||
Text color is set to appropriate value (black for Modern, white for Classic) to make it visible when the align menulist has the focus. Images were tweaked so the top, middle, and bottom attributes show a bit more clearly when selected. There will always be a potential problem with visibility of selected text because a user selects that color via OS settings. While most users will have a dark colored selection (which this fix assumes), some may not. This problem exists for all text in menulists, not just this example.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•24 years ago
|
||
I hate to reopen this bug, I but I see a much cleaner solution to the problem than the one that was checked in. cmanske e-mailed me about this bug earlier in the week but I didn't have a chance to look closely at it then. The menulist in question seems to be built in a somewhat overcomplicated way. There is a far simpler way to do it, the key being the use of the "data" attribute on the menulist. See the forthcoming patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 15•24 years ago
|
||
A point for future reference when changing colors in classic - don't use colors like "white" -- classic uses the CSS2 system colors wherever possible. In this case, the correct color to use for the menulist text would be HighlightText.
Status: NEW → ASSIGNED
Assignee | ||
Comment 16•24 years ago
|
||
Assignee | ||
Comment 17•24 years ago
|
||
cmanske and sfraser, can you review this again?
Assignee | ||
Updated•24 years ago
|
Target Milestone: mozilla0.8 → mozilla0.9
Comment 18•24 years ago
|
||
r=cmanske
Assignee | ||
Comment 19•23 years ago
|
||
hyatt sez sr=hyatt
Assignee | ||
Comment 20•23 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•