663546 - [fennec][danish]the update button is slightly under the Firefox logo in about:fennec when the device is in portrait

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. Place the device in portrait mode
2. go to about:fennec

Expected: the update button is short enough where it does not dip under the firefox logo
Actual: the button is slightly under the firefox logo

Comment 1

[Jesper Kristensen]

The text is also a word for word translation, and does not sound right. I will suggest "Søg efter opdateringer", or if it really needs to be short "Find opdateringer".

Comment 2

[Søren Munk Skrøder (extended hiatus)]

The bug concerns the following file:
mobile/chrome/about.dtd
and the following lines:
<!ENTITY aboutPage.checkForUpdates.button       "Check for Updates">
<!ENTITY aboutPage.checkForUpdates.checking     "Looking for updates…">
<!ENTITY aboutPage.checkForUpdates.none         "No updates available">
<!ENTITY aboutPage.checkForUpdates.found        "Update available">

The issue here is that the bounding box for the logo does not leave much room for longer strings than the ones provided by the en-US locale... ;-(

In order to limit the string size, I suggest changing them to:
<!ENTITY aboutPage.checkForUpdates.button       "Find opdateringer">
<!ENTITY aboutPage.checkForUpdates.checking     "Finder opdateringer…">
<!ENTITY aboutPage.checkForUpdates.none         "Ingen opdateringer fundet">
<!ENTITY aboutPage.checkForUpdates.found        "Opdatering klar">

Any comments ?

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I believe that the "Looking for updates", "no updates available" and "Update available" are not bound by a button box currently.  The only one that does is  "Check for Updates"

I am unsure if any of the other ones will appear under the Logo.  Limiting the character string might be a good idea.  Maybe another idea would be to ask for a line feed for the string so that it can be on two lines in the button?

Comment 4

[Søren Munk Skrøder (extended hiatus)]

(In reply to comment #3)
> I believe that the "Looking for updates", "no updates available" and "Update
> available" are not bound by a button box currently.  The only one that does
> is  "Check for Updates"
> 
> I am unsure if any of the other ones will appear under the Logo.  Limiting
> the character string might be a good idea.  Maybe another idea would be to
> ask for a line feed for the string so that it can be on two lines in the
> button?

The 3 strings are not part of a button - they are only labels - but they still are being drawn overlaying the logo.
While it does not affect the vertical placement in the same way that the button box does, it still makes for "visual clutter" to have the text being written on top of the graphics. 
Thus they are subject to the same constraint as the button label, in that they have to be of limited length, and should be addressed within this bug... 

Also - the wordage chosen for the button text should be followed in the subsequent labels, in order to preserve consistency...

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

fixed?

Comment 6

[Søren Munk Skrøder (extended hiatus)]

(In reply to comment #5)
> Created attachment 547819 [details]
> screenshot
> 
> fixed?

Fixed with changeset http://hg.mozilla.org/releases/l10n/mozilla-aurora/da/rev/30e2e0ab2618 

Tested on Firefox Mobile v. 6 Beta, and I can verify that the bug is fixed...

Thanks for bringing this to our attention, Naoki ;-D