663581 - test_bug362788.xhtml and test_bug366645.xhtml are never run

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P5)

Description

[Cameron McCormack (:heycam)]

In testing/mochitests/tests/ there are two mochitests, test_bug362788.xhtml and test_bug366645.xhtml, which are never run.  The index.html in there seems to be a harness for them.  Should we delete these files or move them somewhere to make them run in the normal mochitest suite?

Comment 1

[(not currently active) Ted Mielczarek]

Looks like those are both safebrowsing bugs.

Comment 2

[François Marier [:francois]]

Both bug 362788 and bug 366645 refer to the pre-TLS days of Safe Browsing. These tests are no longer relevant and should be removed.

It turns out only one of these is left:

  testing/mochitest/tests/Harness_sanity/test_bug362788.xhtml

and is the only test referenced in this harness:

  test/mochitest/tests/index.html

Comment 3

[François Marier [:francois]]

Attachment: MozReview Request: Bug 663581 - remove unused test_bug362788.xhtml. r?jmaher

Review commit: https://reviewboard.mozilla.org/r/44213/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44213/

Comment 4

[François Marier [:francois]]

Joel, I'm not sure whether or not you're the right person to review this, but I was hoping you'd have ideas on how to make sure this simple removal doesn't break anything. I couldn't find that test (or harness) used anywhere.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8737968 [details]
MozReview Request: Bug 663581 - remove unused test_bug362788.xhtml. r?jmaher

https://reviewboard.mozilla.org/r/44213/#review40959

thanks for the cleanup!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d126ad46c1cd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d126ad46c1cd