Closed Bug 663622 Opened 8 years ago Closed 8 years ago

notify the user that session restore was enabled

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(2 files)

Since bug 656778 we automatically enable session restore if we detect Panorama usage. We do it silently at the moment but we want a banner to be shown.

The banner and its animation can be found here:

https://bugzilla.mozilla.org/attachment.cgi?id=532424
Attached patch patch v1Splinter Review
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #538964 - Flags: feedback?(raymond)
Comment on attachment 538964 [details] [diff] [review]
patch v1

Looks good!
Attachment #538964 - Flags: feedback?(raymond) → feedback+
Attachment #538964 - Flags: review?(dolske)
Comment on attachment 538964 [details] [diff] [review]
patch v1

Could you post a screenshot and flag someone from UX for a ui-review? r+ with that.
Attachment #538964 - Flags: review?(dolske) → review+
Attachment #538964 - Flags: ui-review?(limi)
Should probably have a button letting you undo the change or taking you to the relevant prefs pane.
Comment on attachment 538964 [details] [diff] [review]
patch v1

Looks good to me on OS X.
Attachment #538964 - Flags: ui-review?(limi) → ui-review+
I'm still concerned that someone who accidentally invokes Panorama and has their session restore behavior changed will not understand how to undo that change.
Blocks: 671330
(In reply to comment #6)
> Should probably have a button letting you undo the change or taking you to
> the relevant prefs pane.

That's a good idea. The pref switch has already landed (bug 656778) so we should land this notification as soon as possible to at least let the user know what happened. Filed follow-up bug 671330.

(In reply to comment #8)
> I'm still concerned that someone who accidentally invokes Panorama and has
> their session restore behavior changed will not understand how to undo that
> change.

The pref is not switched when accidentally invoking Panorama but when we "detect" actual usage (see bug 656778).
http://hg.mozilla.org/mozilla-central/rev/3dba1aa7adc7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Mozilla/5.0 (Windows NT 5.1; rv:8.0a2) Gecko/20110914 Firefox/8.0a2
Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110914 Firefox/9.0a1

Verified on Ubuntu 11.04, Mac OS 10.6, Windows XP and Windows 7.

1. Start firefox with a new profile.
2. Enter Panorama and make some changes, such as moving a tab from one group to another.

The first time the user makes changes in Panorama in a new session the following message is displayed for a few seconds:"Tabs and groups will automatically be restored the next time you start Nightly/Aurora".
Status: RESOLVED → VERIFIED
Created new litmus test case for Aurora branch: https://litmus.mozilla.org/show_test.cgi?id=29782
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.