The default bug view has changed. See this FAQ.

notify the user that session restore was enabled

VERIFIED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 8
Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Since bug 656778 we automatically enable session restore if we detect Panorama usage. We do it silently at the moment but we want a banner to be shown.

The banner and its animation can be found here:

https://bugzilla.mozilla.org/attachment.cgi?id=532424
(Assignee)

Comment 1

6 years ago
Created attachment 538964 [details] [diff] [review]
patch v1
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #538964 - Flags: feedback?(raymond)
Comment on attachment 538964 [details] [diff] [review]
patch v1

Looks good!
Attachment #538964 - Flags: feedback?(raymond) → feedback+
(Assignee)

Updated

6 years ago
Attachment #538964 - Flags: review?(dolske)
(Assignee)

Comment 3

6 years ago
Comment on attachment 538964 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=0c9a3684bc75
Comment on attachment 538964 [details] [diff] [review]
patch v1

Could you post a screenshot and flag someone from UX for a ui-review? r+ with that.
Attachment #538964 - Flags: review?(dolske) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 541317 [details]
Screenshot with banner at the bottom
(Assignee)

Updated

6 years ago
Attachment #538964 - Flags: ui-review?(limi)

Comment 6

6 years ago
Should probably have a button letting you undo the change or taking you to the relevant prefs pane.
Comment on attachment 538964 [details] [diff] [review]
patch v1

Looks good to me on OS X.
Attachment #538964 - Flags: ui-review?(limi) → ui-review+

Comment 8

6 years ago
I'm still concerned that someone who accidentally invokes Panorama and has their session restore behavior changed will not understand how to undo that change.
(Assignee)

Updated

6 years ago
Blocks: 671330
(Assignee)

Comment 9

6 years ago
(In reply to comment #6)
> Should probably have a button letting you undo the change or taking you to
> the relevant prefs pane.

That's a good idea. The pref switch has already landed (bug 656778) so we should land this notification as soon as possible to at least let the user know what happened. Filed follow-up bug 671330.

(In reply to comment #8)
> I'm still concerned that someone who accidentally invokes Panorama and has
> their session restore behavior changed will not understand how to undo that
> change.

The pref is not switched when accidentally invoking Panorama but when we "detect" actual usage (see bug 656778).
(Assignee)

Comment 10

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/3dba1aa7adc7
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 11

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3dba1aa7adc7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Mozilla/5.0 (Windows NT 5.1; rv:8.0a2) Gecko/20110914 Firefox/8.0a2
Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110914 Firefox/9.0a1

Verified on Ubuntu 11.04, Mac OS 10.6, Windows XP and Windows 7.

1. Start firefox with a new profile.
2. Enter Panorama and make some changes, such as moving a tab from one group to another.

The first time the user makes changes in Panorama in a new session the following message is displayed for a few seconds:"Tabs and groups will automatically be restored the next time you start Nightly/Aurora".
Status: RESOLVED → VERIFIED
Created new litmus test case for Aurora branch: https://litmus.mozilla.org/show_test.cgi?id=29782
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.