Closed Bug 663639 Opened 14 years ago Closed 14 years ago

menupopup from XUL not wide enough, works in 3.1.7, not in 5.0b1

Categories

(Core :: XUL, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: 52qtuqm9, Unassigned)

Details

(Keywords: regression)

Attachments

(3 files)

User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.6.17-1.fc14 Firefox/3.6.17 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20110528 Thunderbird/5.0b1 I have a toolbaritem which contains several menupopup elements in the XUL (attached) of my add-on, Send Later 3. Each menupopup is inside a menulist as required, and each menulist has sizetopopup="1". The contents of the menupopups are populated dynamically by JavaScript code in my add-on. In Thunderbird 3.1.7, all of the popup menus are sized properly, i.e., wide enough to make all of their items visible when they are popped up. In Thunderbird 5.0b1 on Windows XP, however, the menupopup labeled "mins" in the XUL is sized to narrowly and its contents are not visible. Oddly, all of the other menupopups have the correct width; it is only this one that doesn't, even though it doesn't appear that there are any differences between it and the others. I've attached a GIF showing the menupopup with the correct width in Thunderbird 3.1.7, and another GIF showing the incorrect width in 5.0b1. I would add that it appears that even the menupopups that are wide enough in 5.0b1 to show their entire contents are narrower than in 3.1.7, so I think changes must have been made in the code that determines how wide menupopups should be, and a bug must have been introduced, unless there is something wrong with my code that I'm missing that was tolerated in 3.1.7 but isn't in 5.0b1. Reproducible: Always
Maybe duplicate of Bug 611991
Aha. The scrollbar width is indeed the issue -- the other popups don't have scrollbars -- but I don't know whether you're right that this is a duplicate of the other bug.
Keywords: regression
Maybe should be Core bug, not Thunderbird bug?
Unless this is some strange style regression, it should indeed by a core bug - you should get more help there.
Component: Toolbars and Tabs → XP Toolkit/Widgets: Menus
Product: Thunderbird → Core
QA Contact: toolbars-tabs → xptoolkit.menus
> sizetopopup="1" That isn't a valid value for sizetopopup. You shouldn't be changing the sizetopopup attribute on menulists, as the default value of 'pref' is already applied.
(In reply to comment #8) > > sizetopopup="1" > > That isn't a valid value for sizetopopup. You shouldn't be changing the > sizetopopup attribute on menulists, as the default value of 'pref' is > already applied. Interesting. I have no idea where I got the idea to put "sizetopopup="1"" in my code. I can't find any documentation online that claim this is legitimate, so I honestly have no idea what prompted me to do it. In any case, you're right that removing "sizetopopup="1"" from my menulists makes the problem go away. So I suppose even though the behavior I observed is a regression in Thunderbird 5, it's a regression that only occurs in cases of programmer error and therefore not worth worrying about? Thanks for the info.
I don't think it's worth worrying about. The patch in bug 623922 should fix other issues with sizetopopup.
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: