Allow require with file extensions

RESOLVED FIXED in Future

Status

Add-on SDK
General
P2
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: irakli, Assigned: irakli)

Tracking

unspecified
Future

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I run into some packages that require modules via string containing `.js` file extension: require('foo/bar.js') which works perfectly fine in other platforms like node.js but in jetpack it fails as .js is appended blindly.

Would be very nice to fix this.
Created attachment 538764 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/188

Pointer to Github pull-request
Comment on attachment 538764 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/188

Warner can you take a look at this ?
Attachment #538764 - Flags: review?(warner-bugzilla)
Assignee: nobody → rFobic
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Target Milestone: --- → Future
Comment on attachment 538764 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/188

current version of the pull request (with the docs.md fix) looks ok to me.
Attachment #538764 - Flags: review?(warner-bugzilla) → review+
https://github.com/mozilla/addon-sdk/commit/3b972447b699dab4d1f3033c61f934e3fb561027
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.