663729 - Validator: Heaps of Global Overwrite messages without location

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Nils Maier [:nmaier]]

ExifViewer 1.65 produced 300+ "Global overwrite" messages, all lacking a location and context, just stating:
> Global variable overwrite
>
> Warning: An attempt was made to overwrite a global variable in some JavaScript code.

The previous version 1.60, which is mostly the same, does not produce such warnings...

Comment 1

[Matt Basta [:basta]]

Can you attach the XPI?

Comment 2

[Nils Maier [:nmaier]]

Attachment: affected XPI

Comment 3

[Nils Maier [:nmaier]]

Attachment: actual affected XPI

Sorry, this one is the right one. The other had a maxVersion override.

Comment 4

[Matt Basta [:basta]]

I've fixed the issue with missing file/line information. The context information is going to take a little more time.

For now though, I can tell you that the problems are all in html files, namely content/unused/rotate.html. I'm too lazy to open the file to figure out whether they're script tags or not, but i'd bet that they're on* attributes.

Comment 5

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/1645b0a25d87af4243ca00481ad4e6ccf216c369

Comment 7

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/f4051a7fa8bd0ee684bf5346c0be352847500960