Closed Bug 663763 Opened 12 years ago Closed 12 years ago

Provide helper function for opening the library in tests

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 7

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

patch
27.09 KB, patch
mak
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
      No description provided.
Attachment #538825 - Flags: review?(mak77)
Attachment #538825 - Flags: review?(mak77) → review?(sdwilsh)
any reason to change reviewer here? I can do this, I'd rather not disturb sdwilsh for this stuff.
Feel free to steal from Shawn. I just had the impression that you're busy with other stuff, since this waited a few days even though I expected this to be a very quick review.
Comment on attachment 538825 [details] [diff] [review]
patch

Review of attachment 538825 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry sometimes context switching is expensive, I'm running through reviews queue now.

So, I like this, the only doubt I still have is whether we may need an additional executeSoon due to the fact some of the Library trees stuff is inited lazily (especially the details pane overlay). I know waitForFocus does that once and I assume if you ran this through try so it may be enough as it is.
But as a protection vs randomness, I'd prefer it this may land first on Places and bake a couple days. I can push it if you don't want to clone the branch.
Attachment #538825 - Flags: review?(sdwilsh) → review+
Feel free to land this on places. That tree appears to be in a bad shape, though...
Yes, I was working on that to be able to merge.
I have a local patch that should fix all livemarks tests random failures, I'll need a review on that but then it should go green. Since these changes are on b-c tests and other failures are on chrome-tests it should be fine.

Will land in the next minutes along with your other bug 663630.
Sorry, it took a while to figure out how to make Mercurial correctly handle your name :)
http://hg.mozilla.org/projects/places/rev/3c59da5d57ac
Whiteboard: [fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/3c59da5d57ac
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Whiteboard: [fixed-in-places]
You need to log in before you can comment on or make changes to this bug.