Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 538829 [details] [diff] [review]
Part 1: Don't use events to detect load-done

The syncload service currently uses load/error events to figure out when it can stop spinning the event loop. It would be much simpler to simply stop spinning once OnStopRequest is called on the stream listener.

Additionally, the syncloadservice implements a scriptable XPCOM service which we don't seem to use anywhere in our code, so we should just nuke it.
Attachment #538829 - Flags: review?(jst)
Created attachment 538830 [details] [diff] [review]
Part 2: kill syncload XPCOM service
Attachment #538830 - Flags: review?(jst)

Updated

6 years ago
Attachment #538830 - Attachment is patch: true
Attachment #538830 - Attachment mime type: text/x-patch → text/plain
Created attachment 538833 [details] [diff] [review]
Part 2: Kill syncload XPCOM service

Nuked and inlined another function since it was only used in one place.
Attachment #538830 - Attachment is obsolete: true
Attachment #538830 - Flags: review?(jst)
Attachment #538833 - Flags: review?(jst)
Created attachment 538837 [details] [diff] [review]
Part 2: Kill syncload XPCOM service

Erm.. that last patch was borked. This one's correct.
Attachment #538833 - Attachment is obsolete: true
Attachment #538833 - Flags: review?(jst)
Attachment #538837 - Flags: review?(jst)

Updated

6 years ago
Attachment #538829 - Flags: review?(jst) → review+

Updated

6 years ago
Attachment #538837 - Flags: review?(jst) → review+
Checked in!

http://hg.mozilla.org/mozilla-central/rev/44c904e24e4d
http://hg.mozilla.org/mozilla-central/rev/0830b8ed9f02
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.