Closed Bug 663768 Opened 9 years ago Closed 9 years ago

Clean up syncloadservice

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sicking, Assigned: sicking)

References

Details

Attachments

(2 files, 2 obsolete files)

The syncload service currently uses load/error events to figure out when it can stop spinning the event loop. It would be much simpler to simply stop spinning once OnStopRequest is called on the stream listener.

Additionally, the syncloadservice implements a scriptable XPCOM service which we don't seem to use anywhere in our code, so we should just nuke it.
Attachment #538829 - Flags: review?(jst)
Attachment #538830 - Attachment is patch: true
Attachment #538830 - Attachment mime type: text/x-patch → text/plain
Nuked and inlined another function since it was only used in one place.
Attachment #538830 - Attachment is obsolete: true
Attachment #538830 - Flags: review?(jst)
Attachment #538833 - Flags: review?(jst)
Erm.. that last patch was borked. This one's correct.
Attachment #538833 - Attachment is obsolete: true
Attachment #538833 - Flags: review?(jst)
Attachment #538829 - Flags: review?(jst) → review+
Attachment #538837 - Flags: review?(jst) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.