Created attachment 538829 [details] [diff] [review] Part 1: Don't use events to detect load-done The syncload service currently uses load/error events to figure out when it can stop spinning the event loop. It would be much simpler to simply stop spinning once OnStopRequest is called on the stream listener. Additionally, the syncloadservice implements a scriptable XPCOM service which we don't seem to use anywhere in our code, so we should just nuke it.
Created attachment 538830 [details] [diff] [review] Part 2: kill syncload XPCOM service
Created attachment 538833 [details] [diff] [review] Part 2: Kill syncload XPCOM service Nuked and inlined another function since it was only used in one place.
Created attachment 538837 [details] [diff] [review] Part 2: Kill syncload XPCOM service Erm.. that last patch was borked. This one's correct.
6 years ago
Checked in! http://hg.mozilla.org/mozilla-central/rev/44c904e24e4d http://hg.mozilla.org/mozilla-central/rev/0830b8ed9f02