663842 - watched components are bubbled up via user watching

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Josh Matthews [:jdm]]

I received an email from a component I do not watch, with nobody CCed whom I watch. There was no reason given for why I received it.  It was in Networking: Domain Lists, and I watch Networking among many components.

Comment 1

[:glob ✱]

the headers from the email in question are:

X-Bugzilla-Reason: None
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: Component-Watcher [e-mail]
X-Bugzilla-Classification: Components
X-Bugzilla-Product: Core
X-Bugzilla-Component: Networking: Domain Lists
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: [e-mail]
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: --
X-Bugzilla-Assigned-To: [e-mail]
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: 

josh is watching the [e-mail] user.

i suspect this means that jduell is watching the 'Networking: Domain Lists' component, and josh is receiving a copy of this email because he's watching jduell.

i don't think this is the correct behavour, i'll have to do some investigation.

Comment 2

[:glob ✱]

confirmed; if you watch a user who is watching a component, you receive their component notifications.  this is undesirable.

Comment 3

[:glob ✱]

component-watching was incorrectly identifying itself as a direct reason for an email, instead of a watch, which resulted in this chain.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/ComponentWatching/Extension.pm
modified extensions/ComponentWatching/template/en/default/hook/global/reason-descs-end.none.tmpl
Committed revision 7766.

the fix isn't live on production yet, should be live some time this week.