663861 - Allow changing between gingerbread/froyo/honeycomb themes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch v1

For (addon/normal) development, its nice to be able to flip between different themes. One hacky way to do this (proposed by mfinkle) is to just give all the themes names and move between them by flipping prefs.

This patch+addon does that, but can leave the UI a little messy. I'm enabling the restart button in the addon when you change themes so that you can get back to a usable ui. Not the cleanest thing in the world, but IMO not worth putting a ton of extra time into.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Quick (restartless) extensions

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 538932 [details] [diff] [review]
Patch v1

Let's see what how this works.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b44b26309f29

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Extension

Whoops. Some sort of name/install.rdf problem in the other extension I think.

Comment 5

[microrffr]

Did you upload that as a patch instead of an extension?

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 539022 [details]
Extension

Yep. Thanks

Comment 7

[Andreea Pod]

Verified fixed on Nightly:  Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110711 Firefox/8.0a1 Fennec/8.0a1

but on Aurora I was not able to install the extension, build id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a2) Gecko/20110711 Firefox/7.0a2 Fennec/7.0a2 

Device: LG Optimus 2X

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Extension

Thanks for checking. Updated this with * for the max-version.

Comment 9

[Carla Nadastean]

Verified on Beta: Mozilla/5.0 (Android; Linux armv7l; rv:7.0) Gecko/20110830 Firefox/7.0 Fennec/7.0:

I was able to install the extension successfully.

Restart is required when the theme is changed, but UI is still messy after theme is selected. 

Reopening bug since the UI is messy even if the theme is not changed (only selected from the drop-down menu.)

Comment 10

[Martijn Wargers (dead)]

Carla, please file a new bug for the issues that you are seeing and make it blocking this bug.

Comment 11

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110902 Firefox/9.0a1 Fennec/9.0a1