Allow changing between gingerbread/froyo/honeycomb themes

VERIFIED FIXED in Firefox 7

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

(Depends on: 1 bug)

Trunk
Firefox 7

Details

Attachments

(2 attachments, 2 obsolete attachments)

1.72 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
4.62 KB, application/x-xpinstall
Details
(Assignee)

Description

7 years ago
Created attachment 538932 [details] [diff] [review]
Patch v1

For (addon/normal) development, its nice to be able to flip between different themes. One hacky way to do this (proposed by mfinkle) is to just give all the themes names and move between them by flipping prefs.

This patch+addon does that, but can leave the UI a little messy. I'm enabling the restart button in the addon when you change themes so that you can get back to a usable ui. Not the cleanest thing in the world, but IMO not worth putting a ton of extra time into.
(Assignee)

Comment 1

7 years ago
Created attachment 538933 [details]
Quick (restartless) extensions
Assignee: nobody → wjohnston
(Assignee)

Updated

7 years ago
Attachment #538932 - Flags: review?(mark.finkle)
Comment on attachment 538932 [details] [diff] [review]
Patch v1

Let's see what how this works.
Attachment #538932 - Attachment is patch: true
Attachment #538932 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [inbound]

Comment 3

7 years ago
http://hg.mozilla.org/mozilla-central/rev/b44b26309f29
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
(Assignee)

Comment 4

7 years ago
Created attachment 539022 [details]
Extension

Whoops. Some sort of name/install.rdf problem in the other extension I think.
Attachment #538933 - Attachment is obsolete: true

Comment 5

7 years ago
Did you upload that as a patch instead of an extension?
(Assignee)

Comment 6

7 years ago
Comment on attachment 539022 [details]
Extension

Yep. Thanks
Attachment #539022 - Attachment is patch: false
(Assignee)

Updated

7 years ago
Attachment #539022 - Attachment mime type: text/plain → application/x-xpinstall

Comment 7

7 years ago
Verified fixed on Nightly:  Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110711 Firefox/8.0a1 Fennec/8.0a1

but on Aurora I was not able to install the extension, build id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a2) Gecko/20110711 Firefox/7.0a2 Fennec/7.0a2 

Device: LG Optimus 2X
(Assignee)

Comment 8

7 years ago
Created attachment 545779 [details]
Extension

Thanks for checking. Updated this with * for the max-version.
Attachment #539022 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Attachment #545779 - Attachment mime type: application/octet-stream → application/x-xpinstall

Comment 9

7 years ago
Verified on Beta: Mozilla/5.0 (Android; Linux armv7l; rv:7.0) Gecko/20110830 Firefox/7.0 Fennec/7.0:

I was able to install the extension successfully.

Restart is required when the theme is changed, but UI is still messy after theme is selected. 

Reopening bug since the UI is messy even if the theme is not changed (only selected from the drop-down menu.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Carla, please file a new bug for the issues that you are seeing and make it blocking this bug.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 683484
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110902 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.