Closed Bug 663894 Opened 9 years ago Closed 9 years ago

Tracking bug for build and release of Firefox 5.0

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(17 files, 9 obsolete files)

1.50 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
4.59 KB, patch
nthomas
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
16.71 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
10.97 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
4.23 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
10.10 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
1.28 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
10.20 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
11.98 KB, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
623 bytes, patch
christian
: review+
Details | Diff | Splinter Review
847 bytes, patch
rail
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
24.40 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
19.60 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
35.10 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
101.24 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
4.52 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
2.32 KB, patch
catlee
: review+
bhearsum
: checked-in+
Details | Diff | Splinter Review
Waiting on a go
Depends on: 663896
Attachment #538955 - Flags: review?(rail) → review+
Comment on attachment 538955 [details] [diff] [review]
stop caring about isFinalRelease in tagging

Landed this.
Attachment #538955 - Flags: checked-in+
Duplicate of this bug: 659721
Attached patch mozilla-release release config (obsolete) — Splinter Review
I decided not to set nextVersion to 5.0.1, because it's unlikely we'll be having one, and thought it best to avoid confusion.

I enabled partner repacks here, and disabled them in 2.0.

I turned l10nMerge off, but I haven't got confirmation from anyone that we want to do that, yet.

Similar for l10n-changesets, I'm not sure if that's going to be our final set of locales.
Attachment #539210 - Flags: review?(rail)
Attachment #539210 - Flags: review?(nrthomas)
I used this patcher config in my staging run, and it worked as expected: The bumper changed the URLs to staging ones, added the <5.0> section, re-arranged a couple of things, and added a few "beta" things (beta-dir, beta-url). Because I don't have "beta" listed as a channel, these aren't actually used, but they're harmless. We should fix patcher-config-bump.pl to support this scenario better at some point.

One other caveat: the updates builder will fail, being unable to push the aus2.beta snippets. This will be after it has uploaded and pushed the test snippets, and after it has uploaded the release snippets. I'm not really sure how to fix this issue in time for the release, so I'm planning to just live with it, and manually kick off the post-updates tasks, and manually run the snippet comparison step.

I'm still waiting on some of the update verify chunks to finish, but the logs I've looked at have looked fine.
Attachment #539279 - Flags: review?(rail)
Attachment #539279 - Flags: review?(nrthomas)
Attached patch add update verify configs (obsolete) — Splinter Review
Attachment #539325 - Flags: review?(rail)
Attachment #539325 - Flags: review?(nrthomas)
Comment on attachment 539279 [details] [diff] [review]
basic mozilla-release patcher config

Turns out we want to go to beta with this release, so this needs a minor tweak.
Attachment #539279 - Attachment is obsolete: true
Attachment #539279 - Flags: review?(rail)
Attachment #539279 - Flags: review?(nrthomas)
Attachment #539210 - Attachment is obsolete: true
Attachment #539210 - Flags: review?(rail)
Attachment #539210 - Flags: review?(nrthomas)
Attachment #539344 - Flags: review?(rail)
Attachment #539344 - Flags: review?(nrthomas)
Comment on attachment 539344 [details] [diff] [review]
patcher config with beta channel enabled

Sorry for the churn, after discussion on IRC, it seems like the best thing to do is let the automation create the 4.0rc1/rc2/4.0.1 -> 5.0 snippets on release + test channels, and do the 5.0b* -> 5.0 ones by hand, in a separate patcher config (probably mozBeta). So, my previous patch ends up being correct for mozRelease.
Attachment #539344 - Attachment is obsolete: true
Attachment #539344 - Flags: review?(rail)
Attachment #539344 - Flags: review?(nrthomas)
Attachment #539279 - Attachment is obsolete: false
Attachment #539279 - Flags: review?(rail)
Attachment #539279 - Flags: review?(nrthomas)
Same as the last version, except enable "mozilla-release" on pm01 instead of "mozilla-beta".
Attachment #539365 - Flags: review?(rail)
Attachment #539365 - Flags: review?(nrthomas)
Attachment #539279 - Flags: review?(nrthomas) → review+
Comment on attachment 539325 [details] [diff] [review]
add update verify configs

>diff --git a/release/updates/mozRelease-firefox-linux.cfg b/release/updates/mozRelease-firefox-linux.cfg
...
>+# 4.0rc1 linux - full check
>+release="4.0" product="Firefox" platform="Linux_x86-gcc3" build_id="20110303140816" locales="de en-US ru" channel="betatest" patch_types="complete" from="/firefox/releases/4.0/linux-i686/%locale%/firefox-4.0.tar.bz2"

Looks like the wrong path in from, should be .../releases/4.0rc1/.... instead of /4.0/ - same issue in all four configs. Looks like that problem is in moz20-firefox-<platform>.cfg too, and moz20-firefox-linux.cfg says 'linux64 in comments'. r+ if you fix them all up.
Attachment #539325 - Flags: review?(nrthomas) → review+
Comment on attachment 539365 [details] [diff] [review]
mozilla-release release configs, v2

Review of attachment 539365 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. We should switch this
  releaseConfig['ausServerUrl']        = 'https://aus2.mozilla.org'
to aus3.m.o for 2.0 and beta since that's where the apps are querying. It's possible that will break https if the cert issuer is unknown on our build slaves, in which case we can revert to aus2 as a short term fix. Bug 658066 is going to redirect aus2 to aus3 anyway.

::: mozilla/release-firefox-mozilla-2.0.py
@@ +61,3 @@
>  }
>  
>  # Platform configuration

Did you mean to toggle
  releaseConfig['doPartnerRepacks']    = True
to False here too?
Attachment #539365 - Flags: review?(nrthomas) → review+
Comment on attachment 539365 [details] [diff] [review]
mozilla-release release configs, v2

* partner repacks should be disabled in *-2.0.py (releaseConfig['doPartnerRepacks'] = False)
* the patch may be bitrotten, 5.0b7 is the last version
Attachment #539365 - Flags: review?(rail) → review+
Comment on attachment 539325 [details] [diff] [review]
add update verify configs

I'll double Nick here. Just make sure that 4.0rc1 has from="...4.0rc1..."
Attachment #539325 - Flags: review?(rail) → review+
(In reply to comment #11)
> Comment on attachment 539325 [details] [diff] [review] [review]
> add update verify configs
> 
> >diff --git a/release/updates/mozRelease-firefox-linux.cfg b/release/updates/mozRelease-firefox-linux.cfg
> ...
> >+# 4.0rc1 linux - full check
> >+release="4.0" product="Firefox" platform="Linux_x86-gcc3" build_id="20110303140816" locales="de en-US ru" channel="betatest" patch_types="complete" from="/firefox/releases/4.0/linux-i686/%locale%/firefox-4.0.tar.bz2"
> 
> Looks like the wrong path in from, should be .../releases/4.0rc1/....
> instead of /4.0/ - same issue in all four configs. Looks like that problem
> is in moz20-firefox-<platform>.cfg too, and moz20-firefox-linux.cfg says
> 'linux64 in comments'. r+ if you fix them all up.

Good catch, will do.

(In reply to comment #12)
> Comment on attachment 539365 [details] [diff] [review] [review]
> mozilla-release release configs, v2
> 
> Review of attachment 539365 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> Looks fine to me. We should switch this
>   releaseConfig['ausServerUrl']        = 'https://aus2.mozilla.org'
> to aus3.m.o for 2.0 and beta since that's where the apps are querying. It's
> possible that will break https if the cert issuer is unknown on our build
> slaves, in which case we can revert to aus2 as a short term fix. Bug 658066
> is going to redirect aus2 to aus3 anyway.

Sounds good, will do.

> ::: mozilla/release-firefox-mozilla-2.0.py
> @@ +61,3 @@
> >  }
> >  
> >  # Platform configuration
> 
> Did you mean to toggle
>   releaseConfig['doPartnerRepacks']    = True
> to False here too?

Yeah, whoops.


Thanks for the great reviews guys!
Fixed all of the 4.0 vs 4.0rc1 stuff, and the comments in the 2.0 linux config.
Attachment #539325 - Attachment is obsolete: true
Attachment #539577 - Flags: review?(rail)
Fixed AUS URL and 2.0 partner repack config.
Attachment #539365 - Attachment is obsolete: true
Attachment #539578 - Flags: review?(rail)
Attachment #539578 - Flags: review?(rail) → review+
Attachment #539577 - Flags: review?(rail) → review+
Attachment #539279 - Flags: review?(rail) → checked-in+
Attachment #539577 - Flags: checked-in+
Re l10n: please use the same changesets as for Firefox 5 Beta Build 6 and 7.
Thank you Staś, will do!
Kev tells me that we need to provide complete updates only for Yahoo! partner builds. We'll need to manually generate snippets for the following partner channels (all platforms):
release-cck-yahoode
release-cck-yahoode
release-cck-yahoode
release-cck-yahoodek
release-cck-yahoode
release-cck-yahoode
release-cck-yahooau
release-cck-yahooauk
release-cck-yahooca
release-cck-yahoocak
release-cck-yahoogb
release-cck-yahoogb
release-cck-yahoogb
release-cck-yahoogbk
release-cck-yahooin
release-cck-yahooink
release-cck-yahoomy
release-cck-yahoomyk
release-cck-yahoonz
release-cck-yahoonzk
release-cck-yahooph
release-cck-yahoophk
release-cck-yahoosg
release-cck-yahoosgk
release-cck-yahoo
release-cck-yahoo
release-cck-yahook
release-cck-yahooxe
release-cck-yahooxe
release-cck-yahooar
release-cck-yahooark
release-cck-yahooes
release-cck-yahooes
release-cck-yahooesk
release-cck-yahoomx
release-cck-yahoomxk
release-cck-yahooe1
release-cck-yahooe1k
release-cck-yahoofr
release-cck-yahoocf
release-cck-yahoocfk
release-cck-yahoofr
release-cck-yahoofr
release-cck-yahoofrk
release-cck-yahooid
release-cck-yahooidk
release-cck-yahooit
release-cck-yahooit
release-cck-yahooitk
release-cck-yahookr
release-cck-yahookrk
release-cck-yahoobr
release-cck-yahoobrk
release-cck-yahooth
release-cck-yahoothk
release-cck-yahoovn
release-cck-yahoovnk
release-cck-yahoohk
release-cck-yahoohkk
release-cck-yahootw
release-cck-yahootwk

We did this once before, https://bugzilla.mozilla.org/show_bug.cgi?id=554992 has some notes on it.
Attachment #539578 - Flags: checked-in+
I decided not to do partials for 5.0b7 -> 5.0, because we don't have many users there, and I don't know what the implications of having two sets of partials will be.
Attachment #539779 - Flags: review?(rail)
Attachment #539779 - Flags: review?(rail) → review+
I bumped these manually with update-verify-bump.pl, and then dropped "partial" from the list of patch types, because we're not providing them.
Attachment #539782 - Flags: review?(rail)
Attachment #539779 - Flags: checked-in+
Attachment #539782 - Flags: review?(rail) → review+
Attachment #539782 - Flags: checked-in+
Attached patch enable xulrunnerSplinter Review
Attachment #539791 - Flags: review?(rail)
Attachment #539791 - Flags: review?(rail) → review+
Attachment #539791 - Flags: checked-in+
Order of operations for pushing to mirrors:
- Push files to internal mirrors only
- Push index.html files to full set of mirrors
- <wait awhile so they all get them>
- Push files to full set of mirrors

We can probably do the first two points around the same time. We'll need to add something like this to the rsync exclude file to enable us to push index files without pushing the builds themselves.
+ firefox
+ firefox/releases
+ firefox/releases/5.0
+ firefox/releases/5.0/*/
+ firefox/releases/5.0/*/*/
+ firefox/releases/5.0/*/*/*/
+ firefox/releases/5.0/**index.html
- firefox/releases/5.0/**
Anthony reminded me that we need to provide these beta users with updates, too. Contrary to earlier Betas, I'm using the mozBeta patcher config, because we'll want to continue bringing these users forward to the latest beta when we hit 6.0b1.
Attachment #540043 - Flags: review?(rail)
I didn't add 4.0rc1, 4.0rc2, or 4.0.1 here, because they're already getting tested in mozRelease-*, no need to duplicate that effort.
Attachment #540045 - Flags: review?(rail)
Attachment #540045 - Flags: review?(rail) → review+
Attachment #540043 - Flags: review?(rail) → review+
Attachment #540043 - Flags: checked-in+
Attachment #540045 - Flags: checked-in+
Christian, I'd like to push index files to the mirrors today, to make sure they all pick it up before we push the rest of the files on Monday. This is basically the same thing we used for Firefox 4 with updated verbiage and links.
Attachment #540139 - Flags: review?(clegnitto)
When we ship on Tuesday, we'll be throttling updates to 33% (that is to say, 33% of background update checks will receive an update, the other 67% will not).
Comment on attachment 540139 [details] [diff] [review]
proposed index.html to push to mirrors

Looks good, I tried it locally and it looked right
Attachment #540139 - Flags: review?(clegnitto) → review+
Attached patch bump 3.6 branch throttling (obsolete) — Splinter Review
AUS config patch to bump 3.6 branch throttling. To be landed on release day.
Attachment #540491 - Flags: review?(rail)
Attachment #540491 - Flags: review?(rail) → review+
Attached patch update AUS throttling (obsolete) — Splinter Review
Per e-mail, 3.6.18 -> 4.0.1 is to be unthrottled, so we bump the throttling there to the next version. 4.0, 4.0.1 -> 5.0 is to be throttled at 33% to start with.
Attachment #540660 - Flags: review?(nrthomas)
Comment on attachment 540660 [details] [diff] [review]
update AUS throttling

lgtm
Attachment #540660 - Flags: review?(nrthomas) → review+
Attachment #540491 - Attachment is obsolete: true
Attachment #540660 - Attachment is obsolete: true
Attachment #540679 - Flags: review?(rail)
Attachment #540679 - Flags: review?(rail) → review+
Comment on attachment 540679 [details] [diff] [review]
update 5.0 throttling patch to throttle 4.0 and 4.0.1

Landed this. Needs to get updated close to release time, before 4.0 -> 5.0 snippets are pushed.
Attachment #540679 - Flags: checked-in+
Depends on: 665864
Per e-mail, we'll be updating most of the 3.5 releases to 5.0 with unadvertised manual updates. I decided not to do the alphas, betas, or RCs because I didn't think it was worth the extra snippets.

In order to block PPC users of releases earlier than 3.5.16 we'll need to add a section for 3.5 here: http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/index.php#96.
Attachment #540794 - Flags: review?(catlee)
Like 3.5, we're updating 3.6 users to 5.0 with an unadvertised manual update. Unlike 3.5, we can't block PPC users through index.php, because we want to be able to update them to 3.6.19 at a later time. Instead, we won't be updating any Mac builds that we can't identify by Build Target, which is everything prior to 3.6.12.
Attachment #540797 - Flags: review?(catlee)
Attachment #540797 - Flags: review?(catlee) → review+
Attachment #540794 - Flags: review?(catlee) → review+
Attachment #540797 - Flags: checked-in+
Attachment #540794 - Flags: checked-in+
Attachment #540827 - Flags: review?(catlee)
Attachment #540820 - Flags: review?(catlee) → review+
Comment on attachment 540827 [details] [diff] [review]
add 3.5 and 3.6 releases to AUS configs

get rid of the extra 3.6.19 line and you're golden
Attachment #540827 - Flags: review?(catlee) → review+
Attached patch block PPC users on 3.5 (obsolete) — Splinter Review
This isn't 100% ideal, but 3.5 users can't make it past 3.6 anyways...so I don't see great harm in doing it...the benefit of moving x86 users to 5.0 outweighs any harm IMHO.
Attachment #540865 - Flags: review?(nrthomas)
Attachment #540820 - Flags: checked-in+
I copied the update verify lines from the minor update verify configs, and as such, got some locales in them that we don't have in 5.0. All of: as, ka, mn, and oc have been dropped since 3.5/3.6, so we shouldn't test for them here...
Attachment #541129 - Flags: review?(catlee)
Attachment #541134 - Flags: review?(catlee)
Attachment #540827 - Attachment is obsolete: true
Attachment #541129 - Flags: review?(catlee) → review+
Attachment #541134 - Flags: review?(catlee) → review+
Attachment #541129 - Flags: checked-in+
Comment on attachment 540865 [details] [diff] [review]
block PPC users on 3.5

Via IRC:
[12:42] <rhelmer> bhearsum: yeah that patch lgtm, sorry for delay had to step away for a sec
Attachment #540865 - Flags: review?(nrthomas) → review+
Per r-d, we should be unthrottling 4.0 and 4.0.1 today. May as well batch it together with the 3.5/3.6 stuff.
Attachment #541417 - Flags: review?(catlee)
Attachment #541417 - Flags: review?(catlee) → review+
Attachment #541134 - Attachment is obsolete: true
Comment on attachment 540865 [details] [diff] [review]
block PPC users on 3.5

We decided not to ship these updates last minute, so this patch isn't going to be used :(.
Attachment #540865 - Attachment is obsolete: true
Comment on attachment 541417 [details] [diff] [review]
update AUS throttling v3, remove 4.0* throttles

I landed this patch, except for the 3.5 parts, because we decided not to ship that update.
Attachment #541417 - Flags: checked-in+
Depends on: 666738
Per release-drivers, 3.6.2 -> 3.6.17 should go to 3.6.18 instead of 5.0 directly, so we can theoretically move people to a more secure version sooner. This requires some restoring of snippets from backup, and then landing this patch.
Attachment #541507 - Flags: review?(catlee)
Attachment #541507 - Flags: review?(catlee) → review+
Depends on: 666774
Attachment #541507 - Flags: checked-in+
We finished up last week. See also: bug 666953 for a last minute XULRunner fix.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Depends on: 666953
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.