663901 - requests for missing files email us

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P2)

Description

[Wil Clouser [:clouserw]]

Googlebot is noming our file viewer and we're getting a million emails about it:

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/files/decorators.py", line 65, in wrapper
   response = func(request, obj, *args, **kw)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/views/decorators/http.py", line 147, in inner
   response = func(request, *args, **kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/files/views.py", line 70, in browse
   data['content'] = viewer.read_file()

 File "/data/amo_python/www/prod/zamboni/apps/files/helpers.py", line 140, in read_file
   with open(self.selected['full'], 'r') as opened:

IOError: [Errno 2] No such file or directory: '/mnt/netapp_amo/addons.mozilla.org-remora/shared_storage/tmp/file_viewer/21758/mozapps/shared/richview.xml'

Comment 1

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/2dd36345c98c0247d63c1018c3b589331c2d9fe0

Krupa, if things are still good lets pick to next to stop the emails.