Closed Bug 663916 Opened 9 years ago Closed 8 years ago

Firefox Crash [@ nsSHistory::EvictExpiredContentViewerForEntry(nsISHEntry*) ]

Categories

(Core :: DOM: Navigation, defect, critical)

5 Branch
x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: marcia, Unassigned)

Details

(Keywords: crash, topcrash)

Crash Data

Seen while reviewing trunk crash stats. https://crash-stats.mozilla.com/report/list?signature=nsSHistory::EvictExpiredContentViewerForEntry%28nsISHEntry*%29 to the crashes which occur across all versions. There was a small spike in trunk crashes recently and in the last 3 days it moved into the #2 slot on the trunk.

https://crash-stats.mozilla.com/report/index/bc728fbc-8eb4-426e-8059-7cfd32110613

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsSHistory::EvictExpiredContentViewerForEntry 	docshell/shistory/src/nsSHistory.cpp:1081
1 	xul.dll 	nsSHEntry::Expire 	docshell/shistory/src/nsSHEntry.cpp:846
2 	xul.dll 	HistoryTracker::NotifyExpired 	docshell/shistory/src/nsSHEntry.cpp:73
3 	xul.dll 	nsExpirationTracker<nsSHEntry,3>::AgeOneGeneration 	obj-firefox/dist/include/nsExpirationTracker.h:210
4 	xul.dll 	nsExpirationTracker<nsSHEntry,3>::TimerCallback 	obj-firefox/dist/include/nsExpirationTracker.h:307
5 	xul.dll 	nsTimerImpl::Fire 	xpcom/threads/nsTimerImpl.cpp:424
6 	xul.dll 	nsTimerEvent::Run 	xpcom/threads/nsTimerImpl.cpp:520
7 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:618
8 	xul.dll 	TimerThread::RemoveTimer 	xpcom/threads/TimerThread.cpp:417
9 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:219
10 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:202
11 	mozcrt19.dll 	_VEC_memzero 	
12 	xul.dll 	xul.dll@0x36f37f 	
13 	firefox.exe 	firefox.exe@0x1bb7 	
14 	ntdll.dll 	WinSqmSetIfMaxDWORD 	
15 	ntdll.dll 	_RtlUserThreadStart 	
16 	firefox.exe 	firefox.exe@0x186f 	
17 	firefox.exe 	firefox.exe@0x186f
Crash Signature: [@ nsSHistory::EvictExpiredContentViewerForEntry(nsISHEntry*) ]
Should be resolved by bug 663922.
Is that something we think will happen in the 7.0 timeframe?
Yes, it's a no-brainer patch to write.
Only 4 crashes in the last 4 weeks, 3 of these are on 6.0. Let's assume whatever we fixed in bug 663922 probably fixed this. Resolving as works for me. We can reopen if needed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.