Static docs don't render properly on IE9

RESOLVED FIXED

Status

Add-on SDK
Documentation
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: wbamberg, Assigned: wbamberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cherry-pick-1.0])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
1) IE9 does not support JavaScript's 'const' keyword, so main.js fails, with predictable results. Changing it to 'var' fixes the problem.

2) IE9 does not wrap the list of modules: there is something about the inline display of the <li> elements that it does not like. I'm not sure what the correct fix is: a simple fix would be not to set the display to inline on IE only, so it would only display a single module per line.

I'm not sure if this affects the severity, but these are not regressions: they have been present forever.
(Assignee)

Comment 1

7 years ago
Created attachment 539224 [details] [diff] [review]
Conditional css to make IE rendering work OK

This is kind of a hacky patch, but it's the least-disruptive way I can think of to make the docs render tolerably well on IE.

I've also put the static docs built with this up on to members.shaw.ca/vill/sdk
Assignee: nobody → wbamberg
Attachment #539224 - Flags: review?(myk)
Comment on attachment 539224 [details] [diff] [review]
Conditional css to make IE rendering work OK

r=myk, and a=myk for commission during freeze, although drivers'll probably mark this a blocker.
Attachment #539224 - Flags: review?(myk) → review+
Not a blocker, as it doesn't sound like a common-enough case for our developer audience, but we'll still take the patch as a low-risk ride-along.
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Target Milestone: --- → 1.0
(Assignee)

Comment 4

7 years ago
Landed in: https://github.com/mozilla/addon-sdk/commit/2386171723de995c22e07a6875d988867baf6b9d
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: All → Mac OS X
Priority: P2 → --
Hardware: All → x86
Resolution: --- → FIXED
Target Milestone: 1.0 → ---
Whiteboard: [cherry-pick-1.0]
You need to log in before you can comment on or make changes to this bug.