The default bug view has changed. See this FAQ.

Context Menu doesn't resize properly when switching the window orientation

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: xti, Assigned: mfinkle)

Tracking

({verified-beta})

Firefox 5
Firefox 7
ARM
Android
verified-beta

Details

(Whiteboard: [regression][fennec 5.0b6])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:5.0)Gecko/20110613
Firefox/5.0 Fennec/5.0
Device: Motorola Droid 2
OS: Android 2.2

Steps to reproduce:
1. Open Fennec app
2. Go to http://slickdeals.net/
3. Long tap on Tap and hold down on the Slickdeals banner image link
4. Switch device to landscape

Expected result:
Context Menu resize properly due to device orientation changes at step 4.

Actual result:
The Context Menu does not resize when switching the orientation.
(Reporter)

Updated

6 years ago
Whiteboard: [regression][fennec 5.0b6]
(Reporter)

Comment 1

6 years ago
Created attachment 539179 [details]
screenshot
What's wrong with the screen shot? It seems like the context menu has changed it's size, right?
Oh, I see what you mean. The height overflows.
Created attachment 539289 [details] [diff] [review]
patch

I found two problems: menu overflows and context hint (the url on first row) is white-on-white

Fixes in this patch include:
* Adds the color / background-color to the right elements (context-header gets the background and share-hint / context-hint get color)
* Fixes the overflow issue by adding display: -moz-box to the context-commands richlistbox

The match syncs the contextmenu and the menulist behaviors a bit too:
* Adds flex to the container for the context container
* Makes sizeToContent use the container padding to create the width for the popup
* Makes sure sizetoContent is called before we make the panels visible, in case the richlistitems are larger than the window. We need to resize before they are visible or the UI will pan.
Assignee: nobody → mark.finkle
Attachment #539289 - Flags: review?(wjohnston)
(Assignee)

Updated

6 years ago
tracking-fennec: --- → ?
Comment on attachment 539289 [details] [diff] [review]
patch

Review of attachment 539289 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: mobile/chrome/content/common-ui.js
@@ +1220,1 @@
>    },

Can we rename this._panel to this._container?
Attachment #539289 - Flags: review?(wjohnston) → review+
Created attachment 539333 [details] [diff] [review]
patch for beta

minimal fix needed to fix the overflow in mozilla-beta
Attachment #539333 - Flags: review?(wjohnston)
(Assignee)

Updated

6 years ago
Attachment #539333 - Flags: review?(mbrubeck)
Attachment #539333 - Flags: review?(mbrubeck) → review+
Attachment #539333 - Flags: review?(wjohnston) → review+
(Assignee)

Updated

6 years ago
tracking-fennec: ? → 5+
Comment on attachment 539333 [details] [diff] [review]
patch for beta

minimal beta patch. fennec-only. no nays from IRC and beta triage meeting.
Attachment #539333 - Flags: approval-mozilla-beta+
(Assignee)

Updated

6 years ago
Whiteboard: [regression][fennec 5.0b6] → [regression][fennec 5.0b6][inbound]
Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/d05a24569346 due to a persistent failure in dom/tests/mochitest/dom-level0/test_innerWidthHeight_script.html on Android opt.
Whiteboard: [regression][fennec 5.0b6][inbound] → [regression][fennec 5.0b6]
(In reply to comment #8)
> Backed out in
> http://hg.mozilla.org/integration/mozilla-inbound/rev/d05a24569346 due to a
> persistent failure in
> dom/tests/mochitest/dom-level0/test_innerWidthHeight_script.html on Android
> opt.

Wes - can you think of any reason for this failure?
Verifying Fixed on the beta channel
http://hg.mozilla.org/releases/mozilla-beta/rev/6eb872ce9e29

Mozilla/5.0 (Android; Linux armv7l; rv:5.0) Gecko/20110614 Firefox/5.0 Fennec/5.0

Leaving open re-landing on mozilla-inbound.
Keywords: verified-beta
(In reply to comment #8)
> Backed out in
> http://hg.mozilla.org/integration/mozilla-inbound/rev/d05a24569346 due to a
> persistent failure in
> dom/tests/mochitest/dom-level0/test_innerWidthHeight_script.html on Android
> opt.

Philipp - I notice the test failed for your backout too. Could it be intermittent?
My guess would be the other patch in the same push, http://hg.mozilla.org/integration/mozilla-inbound/rev/b9ee105d755c

And note that you don't actually have just one test failure, you have that one, plus a timeout in browser_thumbnails.js that's being called intermittent but is actually permanent, and a timeout in twinopen.
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/19e4a93ebff5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
(Assignee)

Updated

6 years ago
status-firefox6: --- → affected
(Assignee)

Updated

6 years ago
status-firefox5: --- → fixed

Comment 14

6 years ago
VERIFIED FIXED on:

Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110621 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z(Android 2.2)

Note: "Not fixed on aurora"
Status: RESOLVED → VERIFIED

Comment 15

6 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/bb311256b95b
status-firefox6: affected → fixed
Restrict Comments: true
You need to log in before you can comment on or make changes to this bug.