The default bug view has changed. See this FAQ.

AllTabs.jsm needs to remove event listeners from browser windows

RESOLVED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

({mlk})

Trunk
Firefox 7

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 539178 [details] [diff] [review]
patch

AllTabs.jsm seems to be one of the culprits keeping closed browser windows around.
Attachment #539178 - Flags: feedback?(tim.taubert)
(Assignee)

Comment 1

6 years ago
passed tests on try: http://tbpl.mozilla.org/?tree=Try&rev=c86516044ad9
(Assignee)

Updated

6 years ago
Attachment #539178 - Flags: feedback?(tim.taubert) → review?(dietrich)
Uh, we didn't do that? :/ The patch looks good.
(Assignee)

Updated

6 years ago
Attachment #539178 - Flags: review?(gavin.sharp)
Comment on attachment 539178 [details] [diff] [review]
patch

mockEvents seems unnecessary. why not just build realEvents manually and iterate over that? would be a little bit simpler and more readable.
(Assignee)

Comment 4

6 years ago
Created attachment 539780 [details] [diff] [review]
patch v2

> mockEvents seems unnecessary. why not just build realEvents manually and
> iterate over that? would be a little bit simpler and more readable.

done
Attachment #539178 - Attachment is obsolete: true
Attachment #539178 - Flags: review?(gavin.sharp)
Attachment #539178 - Flags: review?(dietrich)
Attachment #539780 - Flags: review?(dietrich)
Comment on attachment 539780 [details] [diff] [review]
patch v2

Review of attachment 539780 [details] [diff] [review]:
-----------------------------------------------------------------

thanks! this needs a test still. Tim, what'd be the best way to go about that?
(Assignee)

Comment 6

6 years ago
Various existing tabview tests verify that the event registration continues to work (http://tbpl.mozilla.org/?tree=Try&rev=c97acee70c78). I don't think the removal can be verified in a sensible way.
Comment on attachment 539780 [details] [diff] [review]
patch v2

Review of attachment 539780 [details] [diff] [review]:
-----------------------------------------------------------------

ok, r=me!
Attachment #539780 - Flags: review?(dietrich) → review+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/c68a54bad24e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Updated

6 years ago
Keywords: mlk
Could you please provide some simple STRs in order to have this issue verified in QA?
(Assignee)

Comment 10

6 years ago
This doesn't need verification.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.