664124 - Include the crash signature (sig:) field in default quicksearches

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Jesse Ruderman]

If we're going to have a crash signature field (bug 577724), we might as well make it easy to search both the new field and the other places that are likely to contain crash signatures.

I assume this won't slow down searches because the crash signature field is empty on most bugs.

(Previously requested in bug 577724 comment 35.)

Comment 1

[David Lawrence [:dkl]]

Currently they only reside in the summary and the new crash signature field. So to clarify you are asking that when some uses the sig: keyword in quicksearch, it would be nice to have both fields searched using the same terms?

dkl

Comment 2

[Jesse Ruderman]

No, I'm asking for it to be included in the default, when you haven't specified a field name.  (Currently summary, whiteboard, product, component, alias, comments[depending on pref], others[depending on input].)

Making "sig:" be a shortcut for "su,crash_signature:" would be an interesting alternative, though.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to include crash signature in standard quick search (v1)

Not really any extension hook for doing this type of thing so I added it to the core Bugzilla code for now. This will work for now and we can look at making it into extension code later.

Also having the same sig: keyword search both summary and crash signature is not currently possible the way Bugzilla is written. May also be something we can look at in the future.

dkl

Comment 4

[:glob ✱]

i'm not a fan of adding this field to all default searches, my preference is for the 'sig:' alias instead.

how about adding something like this to _handle_field_names (completely untested):

         my @fields = split(/,/, $1);
         my @values = split(/,/, $2);
+        if (grep { $_ eq 'sig'} @fields) {
+            @fields = grep { $_ ne 'sig'} @fields;
+            push @fields, ('su', 'crash_signature');
+        }

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> i'm not a fan of adding this field to all default searches

And why not? This seems useful to have for bmo users, IMHO.

Comment 6

[:glob ✱]

Comment on attachment 539341 [details] [diff] [review]
Patch to include crash signature in standard quick search (v1)

r=glob

ok, let's go with this; i can see the now value given previously the crash signature field was being included in the default search anyhow (summary).

Comment 7

[David Lawrence [:dkl]]

Thanks glob. This will be in the next code update, likely next week.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified Bugzilla/Search/Quicksearch.pm
Committed revision 7769.

dkl