664143 - GCHeap Ubuntu Linux compile failure (gcc 4.4 + 4.5)

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

Adapted from an bug report email:

"""
I upgraded the ubuntu on my dev vm this morning and  found that GCHeap::Abort fails to compile.

I think it's pthreads. Looks like m_notificationThread is no longer an lvalue.

  % uname -a
  Linux ubuntu 2.6.38-8-generic-pae #42-Ubuntu SMP Mon Apr 11 05:17:09 UTC 2011 i686 i686 i386 GNU/Linux

I tried gcc-4.4 (it comes with 4.5) and that didn't help.

    void GCHeap::Abort()
    {
    status = kMemAbort;
    EnterFrame *ef = enterFrame;
    
    // If we hit abort, we need to turn m_oomHandling back on so that listeners are guaranteed to get this signal
    // We also need to set m_notoficationThread to NULL in case we hit abort while we were processing another memory status change
    m_oomHandling = true;
=>  //(void*)m_notificationThread = NULL;
"""

I wouldn't be surprised if Bug 648249 and/or Bug 656008 are related.

Comment 1

[Steven Johnson]

Almost certainly; newer gcc versions are pickier about NULL vs 0. Clearly we need to add a "VMPI_THREAD_NULL" type.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.