66418 - nsUrlbarHistory::CheckItemAvailability leaks string

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

nsUrlbarHistory::CheckItemAvailability leaks |char * searchCStr| if it returns
early.  I saw this with the boehm GC.

Possible ways to fix:
 * put in nsMemory::Free all over the place (ugly)
 * use nsXPIDLCString searchCStr and assign to it with the statement:
     *getter_Copies(searchCstr) = searchURL.ToNewCString();
 * use nsCAutoString

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Actually, I take that back.  The better way to fix this is not to convert to C
strings at all, since the only place searchCStr is used is to compare to
arrayCString, which is also converted from a PRUnichar*.  nsCRT has an
strcasecmp that takes PRUnichar* instead of char*.

Comment 2

[Alec Flett]

moving these bugs to History: URLBar

Comment 3

[Alec Flett]

Attachment: fix lots of leaks & simplify code with nsXPIDL[C]String

Comment 4

[Alec Flett]

got me a fix... looking for reviewer/super-reviewer.

Comment 5

[Radha on family leave (not reading bugmail)]

close to what I had in my local tree. r=radha

Comment 6

[Alec Flett]

moving "fix in hand" bugs to moz 0.9

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 8

[Alec Flett]

fix is in

Comment 9

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]