mutt should check exit status rather than grepping stdout for messages

RESOLVED FIXED

Status

Testing Graveyard
Mozmill
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Jeff Hammel, Assigned: Jeff Hammel)

Tracking

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
mutt isn't very robust at detecting failures::

INFO | Running JS Tests
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | Usage: mozmill [options]
INFO | 
INFO | 
INFO | 
INFO | mozmill: error: no such option: --console-level
INFO | 
INFO | All tests were successful.  Ship it!
INFO | 

Instead of grepping for errors, it should check exit status
(Assignee)

Updated

6 years ago
Blocks: 606512
Whiteboard: [mozmill-2.0?]
(Assignee)

Updated

6 years ago
Assignee: nobody → jhammel
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
(Assignee)

Comment 1

6 years ago
Created attachment 545746 [details] [diff] [review]
check for exit status
Attachment #545746 - Flags: review?(fayearthur+bugs)
(Assignee)

Comment 2

6 years ago
In writing attachment 545746 [details] [diff] [review], I realized that fixing processhandler.py in mutt is going to be a pain if a bug also exists in mozprocess.processhandler. I will write a follow-up bug for this
Comment on attachment 545746 [details] [diff] [review]
check for exit status

looks good.
Attachment #545746 - Flags: review?(fayearthur+bugs) → review+
(Assignee)

Comment 4

6 years ago
pushed to master: https://github.com/mozautomation/mozmill/commit/4c2bcec1f7310120d2d85978f7f72cc2d56acc90
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.