Last Comment Bug 664254 - Make nsIDOMFile subclasses immutable when shared across threads.
: Make nsIDOMFile subclasses immutable when shared across threads.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla8
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-14 12:18 PDT by William Chen [:wchen]
Modified: 2011-07-22 06:58 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make DOM Files implement nsIMutable so they can be made immutable for sharing across threads. (3.98 KB, patch)
2011-07-12 10:31 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
jonas: review+
Details | Diff | Splinter Review

Description William Chen [:wchen] 2011-06-14 12:18:09 PDT
nsIDOMFiles should be immutable so that they may safely passed to web workers.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-12 10:31:52 PDT
Created attachment 545408 [details] [diff] [review]
Make DOM Files implement nsIMutable so they can be made immutable for sharing across threads.
Comment 2 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-07-12 11:11:28 PDT
Comment on attachment 545408 [details] [diff] [review]
Make DOM Files implement nsIMutable so they can be made immutable for sharing across threads.

Review of attachment 545408 [details] [diff] [review]:
-----------------------------------------------------------------

Also make sure that nsDOMFileFile::Initialize throws if called on an immutable file.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-22 06:58:45 PDT
http://hg.mozilla.org/mozilla-central/rev/398402eabdb0

Note You need to log in before you can comment on or make changes to this bug.