Closed
Bug 664268
Opened 13 years ago
Closed 13 years ago
Ping fails to keep documentation server alive on IE
Categories
(Add-on SDK Graveyard :: Documentation, defect, P2)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: wbamberg, Assigned: wbamberg)
Details
(Whiteboard: [cherry-pick-1.0])
Attachments
(1 file)
462 bytes,
patch
|
warner
:
review+
|
Details | Diff | Splinter Review |
Although main.js appears to be sending out jQuery AJAX ping requests, and to be getting back successful responses, only the first request is actually received by the server, in IE. It seems that this is because IE caches the ping requests, so only the first one gets sent.
Attachment #539303 -
Flags: review?(warner-bugzilla)
Updated•13 years ago
|
Assignee: nobody → wbamberg
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Target Milestone: --- → 1.0
Comment 1•13 years ago
|
||
Comment on attachment 539303 [details] [diff] [review] Disable caching for the AJAX ping request Looks ok to me. Doesn't cause any problems on my OS-X, at least, and seems like a reasonable fix. The alternative would probably be to switch from GET to a POST, or something else that's not idempotent, so neither jQuery, the browser, or some weird cache that might get in the way could think that it's ok to cache the request.
Attachment #539303 -
Flags: review?(warner-bugzilla) → review+
Comment 2•13 years ago
|
||
a=myk for commission during freeze.
Assignee | ||
Comment 3•13 years ago
|
||
Thanks. Landed in: https://github.com/mozilla/addon-sdk/commit/f943b6aad3a1d12554f6cb45e5bef2dcf3da9b1e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [cherry-pick-1.0]
You need to log in
before you can comment on or make changes to this bug.
Description
•