Closed
Bug 664324
Opened 13 years ago
Closed 12 years ago
[session restore cleanup] Remove trailing whitespace
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 15
People
(Reporter: zpao, Assigned: zpao)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 3 obsolete files)
82.49 KB,
patch
|
zpao
:
review+
|
Details | Diff | Splinter Review |
There's a lot of trailing whitespace and it bothers me. Instead of maybe fixing it piecemeal if a test or surrounding code gets touched, I'd rather just do it all in one go and be more vigilant for new code.
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Assuming these patches are ok, I can do the same to the other files in browser/components/sessionstore as well. Should all the tests have trailing spaces removed too?
Updated•13 years ago
|
Attachment #549482 -
Flags: review?(paul)
Updated•13 years ago
|
Attachment #549483 -
Flags: review?(paul)
Assignee | ||
Comment 3•13 years ago
|
||
I've actually had these and others in my patch queue since I filed this. But the problem I've had is that there's no great time to land this - it's going to be super annoying to people working on larger sessionstore bugs right now (I know bug 516755 which is a big project and bug 587873 which is less bad). This is also going to bitrot fast. I think we should hold off until we have a nice quiet sessionstore period. I should have made it clear here that this is stalled for the time being, so I apologize that you spent the time doing these. Hopefully you didn't spend too long! I can see you're itching for some more bugs to work on, so I'll try to find one that's more ready.
Whiteboard: [ping zpao before working on this]
Comment 4•13 years ago
|
||
Ah that's ok - it didn't take very long to do those
Updated•13 years ago
|
Attachment #549482 -
Flags: review?(paul)
Updated•13 years ago
|
Attachment #549483 -
Flags: review?(paul)
Comment 6•12 years ago
|
||
Attachment #549482 -
Attachment is obsolete: true
Attachment #549483 -
Attachment is obsolete: true
Attachment #627168 -
Flags: review?(paul)
Comment 7•12 years ago
|
||
Attachment #627168 -
Attachment is obsolete: true
Attachment #627168 -
Flags: review?(paul)
Attachment #627365 -
Flags: review?(paul)
Assignee | ||
Updated•12 years ago
|
Attachment #627365 -
Flags: review?(paul) → review+
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ad13022897ba
Status: NEW → ASSIGNED
Whiteboard: [ping zpao before working on this] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad13022897ba
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•