[session restore cleanup] Remove trailing whitespace

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Session Restore
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

unspecified
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 3 obsolete attachments)

There's a lot of trailing whitespace and it bothers me. Instead of maybe fixing it piecemeal if a test or surrounding code gets touched, I'd rather just do it all in one go and be more vigilant for new code.

Comment 1

6 years ago
Created attachment 549482 [details] [diff] [review]
nsSessionStartup.js

Comment 2

6 years ago
Created attachment 549483 [details] [diff] [review]
nsSessionStore.js

Assuming these patches are ok, I can do the same to the other files in browser/components/sessionstore as well.

Should all the tests have trailing spaces removed too?

Updated

6 years ago
Attachment #549482 - Flags: review?(paul)

Updated

6 years ago
Attachment #549483 - Flags: review?(paul)
I've actually had these and others in my patch queue since I filed this. But the problem I've had is that there's no great time to land this - it's going to be super annoying to people working on larger sessionstore bugs right now (I know bug 516755 which is a big project and bug 587873 which is less bad). This is also going to bitrot fast. I think we should hold off until we have a nice quiet sessionstore period.

I should have made it clear here that this is stalled for the time being, so I apologize that you spent the time doing these. Hopefully you didn't spend too long!

I can see you're itching for some more bugs to work on, so I'll try to find one that's more ready.
Whiteboard: [ping zpao before working on this]

Comment 4

6 years ago
Ah that's ok - it didn't take very long to do those

Updated

6 years ago
Attachment #549482 - Flags: review?(paul)

Updated

6 years ago
Attachment #549483 - Flags: review?(paul)
Duplicate of this bug: 724125
Created attachment 627168 [details] [diff] [review]
remove trailing white spaces from nsSessionStartup.js
Attachment #549482 - Attachment is obsolete: true
Attachment #549483 - Attachment is obsolete: true
Attachment #627168 - Flags: review?(paul)
Depends on: 745040
Created attachment 627365 [details] [diff] [review]
removing trailing whitespace from all sessionstore files
Attachment #627168 - Attachment is obsolete: true
Attachment #627168 - Flags: review?(paul)
Attachment #627365 - Flags: review?(paul)
Attachment #627365 - Flags: review?(paul) → review+
https://hg.mozilla.org/integration/fx-team/rev/ad13022897ba
Status: NEW → ASSIGNED
Whiteboard: [ping zpao before working on this] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/ad13022897ba
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.