Closed Bug 664357 Opened 9 years ago Closed 9 years ago

SeaMonkey 2.1 mail compose window back tab bug

Categories

(SeaMonkey :: MailNews: Composition, defect, minor)

defect
Not set
minor

Tracking

(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.4 --- fixed
seamonkey2.5 --- fixed
seamonkey2.6 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 503794 caused a regression.
See http://forums.mozillazine.org/viewtopic.php?f=5&t=2225177

[quote]In SM 2.1's Messenger mail client mail composition window, there appears to be a bug whereby back tabbing from the e-mail body into the SUBJECT field requires more than one back tab (compared to SM 2.0.X and SM 1.X). This can be duplicated as follows:

1. In SM Messenger, hit ctrl-M to open a new mail composition window (plain text mode is used in this procedure).
2. Click inside the (blank) message body area.
3. Press SHIFT-TAB to back tab once - normally in SM 2.0.X, this would immediately back tab into the SUBJECT field. However, in SM 2.1's mail composition window, THREE (or at least more than one) back tab keystrokes are necessary to back up the cursor into the SUBJECT field.
[/quote]

From IRC:

<RattyAway> NeilAway: interesting fallout for your fix to Bug 503794
http://forums.mozillazine.org/viewtopic.php?f=5&t=2225177
<NeilAway> RattyAway: odd, I thought tabIndex="0" was supposed to remove it from the focus order
maybe I meant tabIndex="-1"
<RattyAway> NeilAway: tabindex=0 is special it means the default tab order.
<NeilAway> RattyAway: d'oh I meant -1 didn't I :-(
<RattyAway> NeilAway: well probably.
<NeilAway> RattyAway: I can't remember which is the special value means "you can click but you can't tab to it"
<NeilAway> RattyAway: yeah, I just checked, it is -1, I must have got it confused
Thunderbird has rewritten their attachment pane handling so the equivalent code isn't there any more. Thus, this fix is just for Suite.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #556827 - Flags: review?(neil)
Attachment #556827 - Flags: review?(neil) → review+
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/debf99a26bce
Comment on attachment 556827 [details] [diff] [review]
Patch v1.0 Use tabindex="-1"

Simple regression fix. Requesting comm-aurora and comm-beta approval.
Attachment #556827 - Flags: approval-comm-beta?
Attachment #556827 - Flags: approval-comm-aurora?
Attachment #556827 - Flags: approval-comm-beta?
Attachment #556827 - Flags: approval-comm-beta+
Attachment #556827 - Flags: approval-comm-aurora?
Attachment #556827 - Flags: approval-comm-aurora+
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/f7580538c795
http://hg.mozilla.org/releases/comm-beta/rev/a862b4bac68b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
You need to log in before you can comment on or make changes to this bug.