664411 - Provide a crash id to the client on server crash

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

On any 503, the server logs the traceback on the server and returns an empty body --for security reasons--, instead we should return a unique id the client is able to give us in a bug entry, for us to find in the server(s) logs

Proposal for the body:

"application error: crash id 7a28ca56541418ea83052ff4b275de60"

The traceback logged will be prefixed by this hash

Comment 1

[Tarek Ziadé (:tarek)]

Notice that the response sent is a json string.

Comment 2

[:Atoll]

When this is deployed, we'll need to adjust certain aspects of the Zeus to maintain the application-provided body when an error occurs.  Currently it does not.

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: Adds a crash id feature

Comment 4

[Toby Elliott [:telliott]]

Comment on attachment 539499 [details] [diff] [review]
Adds a crash id feature

Code looks fine, but we need to make sure that both Zeus and the client aren't looking for a particular string in the response before we deploy this.

Comment 5

[:Atoll]

rnewman and i have confirmed that neither the Zeus nor the client care at all what is in the body of a 5xx error response.  this statement applies *only* to 5xx error responses.

Comment 6

[Tarek Ziadé (:tarek)]

done in https://hg.mozilla.org/services/server-core/rev/cbdbba169396a52c5b4935948657e07201b8e531