Last Comment Bug 664434 - Make sure to Destroy the old document when setting a new print document
: Make sure to Destroy the old document when setting a new print document
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Printing: Setup (show other bugs)
: unspecified
: x86_64 Linux
: -- normal with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks: strongparent
  Show dependency treegraph
 
Reported: 2011-06-15 08:10 PDT by Olli Pettay [:smaug]
Modified: 2011-06-16 13:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.32 KB, patch)
2011-06-15 08:10 PDT, Olli Pettay [:smaug]
roc: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-06-15 08:10:48 PDT
Created attachment 539527 [details] [diff] [review]
patch

We handle print documents in a different way than normal documents,
so they, or the original document in DocumentViewer, may not get Destroyed.

The patch adds also some CTOR/DTORs
Comment 1 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-06-15 17:01:06 PDT
Comment on attachment 539527 [details] [diff] [review]
patch

Review of attachment 539527 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 2 Olli Pettay [:smaug] 2011-06-16 13:11:07 PDT
http://hg.mozilla.org/mozilla-central/rev/fb60f6e2f89e

Note You need to log in before you can comment on or make changes to this bug.