Last Comment Bug 664470 - Unlink document some more
: Unlink document some more
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: strongparent
  Show dependency treegraph
 
Reported: 2011-06-15 09:40 PDT by Olli Pettay [:smaug]
Modified: 2011-07-01 15:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.52 KB, patch)
2011-06-15 09:40 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Review
patch (2.13 KB, patch)
2011-06-29 06:39 PDT, Olli Pettay [:smaug]
peterv: review+
Details | Diff | Review
+ space (2.14 KB, patch)
2011-07-01 07:05 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Review

Description Olli Pettay [:smaug] 2011-06-15 09:40:06 PDT
Created attachment 539567 [details] [diff] [review]
patch
Comment 1 Olli Pettay [:smaug] 2011-06-29 06:39:06 PDT
Created attachment 542800 [details] [diff] [review]
patch
Comment 2 Peter Van der Beken [:peterv] 2011-06-29 11:47:29 PDT
Comment on attachment 542800 [details] [diff] [review]
patch

Review of attachment 542800 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +1940,5 @@
>     delete tmp->mBoxObjectTable;
>     tmp->mBoxObjectTable = nsnull;
>   }
>  
> + if (tmp->mListenerManager) {

Missing a space here.
Comment 3 Olli Pettay [:smaug] 2011-07-01 07:05:33 PDT
Created attachment 543425 [details] [diff] [review]
+ space
Comment 4 Olli Pettay [:smaug] 2011-07-01 15:03:32 PDT
http://hg.mozilla.org/mozilla-central/rev/c97034c07fe6

Note You need to log in before you can comment on or make changes to this bug.