664564 - mozmill doesnt work on linux 3 kernels

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

From https://github.com/mozautomation/mozmill/issues/4

While building the chromium webbrowser on a Linux machine with kernel
version 3.0-rc2, it turned out, that Python now reports 'linux3' for
sys.platform. This breaks conditions that check for Linux in many
projects, since the checks are often done like:

sys.platform == 'linux2'

A more relaxed check by sys.platform.startswith('linux'), seems to be
a better solution.

Comment 1

[Jeff Hammel]

For 2.0, if we move to mozinfo (https://bugzilla.mozilla.org/show_bug.cgi?id=606524), we won't need to fix this bug anyway as it already works upstream (no checks for linux2).  Obviously we won't be using mozinfo for 1.5.4 (unless i missed a meeting).

Comment 2

[Jeff Hammel]

Attachment: should work with new kernels for mozmill 1.5.4

This whole patch is just messy. We should just get mozinfo in reasonable shape for mozmill-2 and be done with this nonsense

Comment 3

[cmtalbert]

Comment on attachment 539659 [details] [diff] [review]
should work with new kernels for mozmill 1.5.4

we should do this for 2.0 as well.

Comment 4

[Jeff Hammel]

pushed to hotfix-1.5: https://github.com/mozautomation/mozmill/commit/d3c67c82e978932378fa635bc6c11a20568f4344

We should solve this problem for 2.0, but I would much rather solve it with mozinfo (see comment 1). This is exactly the sort of problem mozinfo is supposed to solve: namely, changing the check for (in this case) operating system can be done in a single place, rather than several.  Will leave open until the 2.0 issue is resolved

Comment 5

[Jeff Hammel]

should be resolved in master (2.0) with the landing of bug 606524

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This has already been fixed for Mozmill 2.