product details missing from ff4/lib/

RESOLVED FIXED

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: ozten, Unassigned)

Tracking

Details

Reporter

Description

8 years ago
The update cron is failing, as it now depends on product_details.

Error: No module named product_details
/data/engagement-dev/python/webifyme.org/update: line 10: Error!!! Exit status of the last command was 1: command not found


In addition to adding django-mozilla-product-details, jingo to ff4/requirements/prod.txt we also need to:

1) cd ff4
   ./manage.py update_product_details
Commit a copy of the product details json under ff4/lib

Please compare
https://github.com/mozilla/webifyme/tree/master/ff4/lib
to
https://github.com/mozilla/markup/tree/master/ffdemo/lib
Reporter

Comment 1

8 years ago
Generated and added missing files

https://github.com/mozilla/webifyme/commit/60a44eec6b93569ebc7c55937832cc784276c0df

Will wait 15 minutes to see if cron mail stops before marking fixed.
Reporter

Comment 2

8 years ago
Got another cron mail :(

Repro'd with a clean checkout.
https://github.com/mozilla/webifyme/commit/b30c8a940e6b9501d2c54f03060d75ab9ec27e70

Will wait another cycle.
Reporter

Comment 3

8 years ago
No dice. I'll try to repro.

Comment 4

8 years ago
Sorry I should have clarified you have to run:

./manage.py update_product_details
Reporter

Comment 5

8 years ago
(In reply to comment #4)
cool. That is how I generated the files for the commit in comment #1
Reporter

Comment 6

8 years ago
This was fixed in the vendor bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.