Mozmill test for adding a tag to a bookmark - 'typed text' via bookmark edit dialog

NEW
Unassigned

Status

Mozilla QA
Mozmill Tests
7 years ago
5 years ago

People

(Reporter: vladmaniac, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Tracking bug for creating a mozmill test for https://litmus.mozilla.org/show_test.cgi?id=10766
(Reporter)

Updated

7 years ago
Assignee: nobody → vlad.maniac
Status: NEW → ASSIGNED

Comment 1

7 years ago
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/14650427
(Reporter)

Comment 2

7 years ago
Created attachment 541012 [details] [diff] [review]
WIP v1.0

This also needs to test if the tag is present in library. We currently do no have library API so for the moment i've marked as //TODO:
Attachment #541012 - Flags: feedback?(hskupin)
Comment on attachment 541012 [details] [diff] [review]
WIP v1.0

>       case "mainFeature_collectionAddons":
>-        nodeCollector.queryNodes("li.cloned #fx4-collection .addons li>a");
>+        nodeCollector.queryNodes("#fx4-collection .addons li>a");

That's another change which should not live in this patch.

>+ * The Initial Developer of the Original Code is the Mozilla Foundation.
>+ * Portions created by the Initial Developer are Copyright (C) 2011
>+ * the Initial Developer. All Rights Reserved.
>+ *
>+ * Contributor(s):
>+ *   Vlad Maniac <vlad.maniac@softvisioninc.eu> (original author)

The original code is by yourself and not the Mozilla Foundation.

>+/**
>+* Tests adding a tag to a bookmark via edit bookmark pane
>+* Verifies existence of the tag in the dialog and in bookmarks Library
>+*/

We have dependencies we cannot fulfill. That way we can not cover the Litmus test with Mozmill.

>+  // Wait for the bookmark edit dialog 
>+  controller.waitForEval("subject._overlayLoaded == true", TIMEOUT, 100, 
>+                         controller.window.top.StarUI);

No waitForEval please.

>+  controller.type(tagField, "Mozilla");
>+  controller.click(doneButton);

You should check if clicking the done button was successful.

>+  // Verify that tag is present in the edit bookmarks panel tag field
>+  controller.click(starButton);
>+  controller.assertValue(tagField, "Mozilla");

Use constants for repeated values.

>+  //TODO: Verify that tag is present in the 'tag' section from library 

As said above, it's not an ideal to test to automate now. It should not have been chosen at this time.

Otherwise f+
Attachment #541012 - Flags: feedback?(hskupin) → feedback+
If this needs a specific API, lets get a blocker bug on file to specify those requirements.
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #4)
> If this needs a specific API, lets get a blocker bug on file to specify
> those requirements.

Vlad, please file any blocker bug(s) as needed.
(Reporter)

Comment 6

6 years ago
(In reply to Maniac Vlad Florin (:vladmaniac) from comment #2)
> Created attachment 541012 [details] [diff] [review] [diff] [details] [review]
> WIP v1.0
> 
> This also needs to test if the tag is present in library. We currently do no
> have library API so for the moment i've marked as //TODO:

This would be the same answer as in 

https://bugzilla.mozilla.org/show_bug.cgi?id=664691#c28
Assignee: vlad.mozbugs → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.