664808 - Tests for HMAC failure conditions

Status: RESOLVED DUPLICATE of bug 664865

(Firefox :: Sync, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Test. v1

These two tests exercise 401 and 404 handling. They fail at this commit:

Author: Richard Newman <[e-mail]>
Date:   Tue Apr 19 12:30:39 2011 -0700

    Bug 645918: attempt to fix random orange in test_bookmarks_engine. r=philiKON

immediately prior to the work for Bug 650208.

There is one commented-out check in this test:

    // TODO: this will change when we correctly handle 401s by aborting the
    // sync and starting again.
    //do_check_true(!hasData == !hasKeys);        // TODO

because after the 401 the server is left in an inconsistent, albeit recoverable, state.

I will file a bug (blocking this one) to address the inconsistency, and then uncomment this check and request review.

Comment 2

[Richard Newman [:rnewman]]

Duping this to the fix+test version.