Closed
Bug 664876
Opened 14 years ago
Closed 14 years ago
Make nsWebSocketEstablishedConnection no longer implement nsIRequest
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
mozilla7
People
(Reporter: jduell.mcbugs, Unassigned)
Details
Attachments
(1 obsolete file)
Somehow a bunch of +nsWebSocketEstablishedConnection methods got stranded at the bottom of the file, separated from the rest of the implementation by nsWebSocket code.
No code changes--this is literally just moving lines within the file.
Attachment #539930 -
Flags: review?(mcmanus)
|
Reporter | |
Comment 1•14 years ago
|
||
Actually, looking at the code some more, I'm not at all clear why we have nsWebSocketEstablishedConnection implement nsIRequest at all. The class is private to bsWebSocket.cpp, and the only nsIRequest method we use is GetLoadGroup (which we use to set the loadgroup of the "real" request, i.e. the nsWebSocketProtocol).
Seems like we should just have a (private) GetLoadGroup method, and not inherit from nsIRequest. Am I missing something?
Summary: code cleanup in nsWebSocket.cpp → Make nsWebSocketEstablishedConnection no longer implement nsIRequest
|
|
Reporter | |
Updated•14 years ago
|
Attachment #539930 -
Attachment is obsolete: true
Attachment #539930 -
Flags: review?(mcmanus)
|
|
Reporter | |
Comment 2•14 years ago
|
||
This bug will obviously be moot if 664894 is not INVALID.
|
|
Reporter | |
Comment 3•14 years ago
|
||
going to factor out nsEstablishedWSCxn in bug 664894
Status: NEW → RESOLVED
Closed: 14 years ago
Component: Networking: WebSockets → Plug-ins
Resolution: --- → WONTFIX
Target Milestone: --- → mozilla7
Version: unspecified → 8 Branch
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•