Created attachment 539992 [details] testcase ###!!! ASSERTION: We shouldn't have another size than small and regular for the moment: 'size == NSSmallControlSize', file widget/src/cocoa/nsNativeThemeCocoa.mm, line 201 The assertion was added in bug 634551.
Created attachment 540498 [details] [diff] [review] Patch v1 The assert is correct and this patch should fix. Though, a better fix should come with bug 665571.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #540498 - Flags: review?(mstange)
Attachment #540498 - Flags: review?(mstange) → review+
Whiteboard: [needs review] → [inbound]
I backed it out because of reftest oranges on OS X: http://hg.mozilla.org/integration/mozilla-inbound/rev/ea1856ff64d1 http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308595010.1308596968.20417.gz
Attachment #540498 - Flags: checkin+ → checkin-
(In reply to comment #2) > I backed it out because of reftest oranges on OS X: > > http://hg.mozilla.org/integration/mozilla-inbound/rev/ea1856ff64d1 > http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308595010. > 1308596968.20417.gz Interesting. It fails on the test I wrote and was passing locally... Yay \o/
The assertion should have been fixed by bug 665571. Test pushed to m-i.
Whiteboard: [in → [inbound]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.