Closed Bug 664925 Opened 10 years ago Closed 10 years ago

"ASSERTION: We shouldn't have another size than small and regular for the moment"

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: jruderman, Assigned: mounir)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, regression, testcase)

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: We shouldn't have another size than small and regular for the moment: 'size == NSSmallControlSize', file widget/src/cocoa/nsNativeThemeCocoa.mm, line 201

The assertion was added in bug 634551.
Depends on: 665571
Attached patch Patch v1Splinter Review
The assert is correct and this patch should fix.
Though, a better fix should come with bug 665571.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #540498 - Flags: review?(mstange)
Whiteboard: [needs review]
Hardware: x86_64 → All
Attachment #540498 - Flags: review?(mstange) → review+
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
Attachment #540498 - Flags: checkin+
Attachment #540498 - Flags: checkin+ → checkin-
(In reply to comment #2)
> I backed it out because of reftest oranges on OS X:
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/ea1856ff64d1
> http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308595010.
> 1308596968.20417.gz

Interesting. It fails on the test I wrote and was passing locally... Yay \o/
Whiteboard: [in
The assertion should have been fixed by bug 665571. Test pushed to m-i.
Whiteboard: [in → [inbound]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/ec99f33d4f76
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.