664925 - "ASSERTION: We shouldn't have another size than small and regular for the moment"

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: We shouldn't have another size than small and regular for the moment: 'size == NSSmallControlSize', file widget/src/cocoa/nsNativeThemeCocoa.mm, line 201

The assertion was added in bug 634551.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

The assert is correct and this patch should fix.
Though, a better fix should come with bug 665571.

Comment 2

[(no longer active)]

I backed it out because of reftest oranges on OS X:

http://hg.mozilla.org/integration/mozilla-inbound/rev/ea1856ff64d1
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308595010.1308596968.20417.gz

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> I backed it out because of reftest oranges on OS X:
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/ea1856ff64d1
> http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1308595010.
> 1308596968.20417.gz

Interesting. It fails on the test I wrote and was passing locally... Yay \o/

Comment 4

[Mounir Lamouri (:mounir)]

The assertion should have been fixed by bug 665571. Test pushed to m-i.

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ec99f33d4f76

Comment 6

[Pulsebot]

Pushed by ffxbld:
https://hg.mozilla.org/releases/mozilla-release/rev/64b58e1da898
Don't set NSZeroSize to say that a given control size isn't available. r=mstange