Merge nsISHistory_2_0_BRANCH into nsISHistory

RESOLVED FIXED in mozilla7

Status

()

Product:
Core
Component:
Document Navigation
Type:
defect
Status:
RESOLVED FIXED
Opened:
8 years ago
Updated:
8 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

({dev-doc-complete})

Version:
Trunk
Target:
mozilla7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments, 1 obsolete attachment)

Merge nsISHistory_2_0_BRANCH v1.1
4.23 KB, patch
emorley
: review+
emorley
: checkin+
Details | Diff | Splinter Review
Remove unnecessary QueryInterface call
1.21 KB, patch
bzbarsky
: review+
dholbert
: checkin+
Details | Diff | Splinter Review
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Comment on attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH

You don't need to change the history CID.  r=me with that change taken out.
Attachment #540190 - Flags: review?(bzbarsky) → review+
Updated for review comments, carrying forwards r+.

For whomever checks this in, it has passed try (comment 1) and has author/commit message set already. Thanks! :-)
Attachment #540190 - Attachment is obsolete: true
Attachment #540219 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/54cfcc5aeb7b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Blocks: 665276
Comment on attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1

>         browser.webNavigation.sessionHistory.
>-          QueryInterface(Ci.nsISHistory_2_0_BRANCH).reloadCurrentEntry();
>+          QueryInterface(Ci.nsISHistory).reloadCurrentEntry();
sessionHistory is already nsISHistory, no need to call QueryInterface again.
Removes unnecessary QueryInterface(Ci.nsISHistory) call, per comment 5.

Thanks for spotting that Neil :-)
Attachment #540321 - Flags: review?(bzbarsky)
Attachment #540219 - Flags: checkin+
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

r=me
Attachment #540321 - Flags: review?(bzbarsky) → review+
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

Reopening so this shows on the checkin-needed searches.

Only the "Remove unnecessary QueryInterface call" patch is left to be landed - thanks! (Has passed try, see comment 7.
Attachment #540321 - Flags: checkin?
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
"Remove unnecessary QueryInterface call" patch landed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/484adb0cf79b
Keywords: checkin-needed
Whiteboard: [inbound]
Attachment #540321 - Flags: checkin? → checkin+
http://hg.mozilla.org/mozilla-central/rev/484adb0cf79b
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
I'm presuming this page needs updating:
https://developer.mozilla.org/en/NsISHistory
Keywords: dev-doc-needed
Keywords: dev-doc-needed → dev-doc-complete
Thanks Trevor :-)
You need to log in before you can comment on or make changes to this bug.