Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Merge nsISHistory_2_0_BRANCH into nsISHistory

RESOLVED FIXED in mozilla7

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

({dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
http://mxr.mozilla.org/mozilla-central/search?string=nsISHistory_2_0_BRANCH
(Assignee)

Updated

6 years ago
Assignee: nobody → bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH

http://dev.philringnalda.com/tbpl/?tree=Try&rev=a03554955ed0

Thanks :-)
Attachment #540190 - Flags: review?(bzbarsky)

Comment 2

6 years ago
Comment on attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH

You don't need to change the history CID.  r=me with that change taken out.
Attachment #540190 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1

Updated for review comments, carrying forwards r+.

For whomever checks this in, it has passed try (comment 1) and has author/commit message set already. Thanks! :-)
Attachment #540190 - Attachment is obsolete: true
Attachment #540219 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/54cfcc5aeb7b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 665276

Comment 5

6 years ago
Comment on attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1

>         browser.webNavigation.sessionHistory.
>-          QueryInterface(Ci.nsISHistory_2_0_BRANCH).reloadCurrentEntry();
>+          QueryInterface(Ci.nsISHistory).reloadCurrentEntry();
sessionHistory is already nsISHistory, no need to call QueryInterface again.
(Assignee)

Comment 6

6 years ago
Created attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

Removes unnecessary QueryInterface(Ci.nsISHistory) call, per comment 5.

Thanks for spotting that Neil :-)
Attachment #540321 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Attachment #540219 - Flags: checkin+
(Assignee)

Comment 7

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=0f7f8aa6e296

Comment 8

6 years ago
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

r=me
Attachment #540321 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 9

6 years ago
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

Reopening so this shows on the checkin-needed searches.

Only the "Remove unnecessary QueryInterface call" patch is left to be landed - thanks! (Has passed try, see comment 7.
Attachment #540321 - Flags: checkin?
(Assignee)

Updated

6 years ago
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
"Remove unnecessary QueryInterface call" patch landed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/484adb0cf79b
Keywords: checkin-needed
Whiteboard: [inbound]
Attachment #540321 - Flags: checkin? → checkin+
http://hg.mozilla.org/mozilla-central/rev/484adb0cf79b
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
(Assignee)

Comment 12

6 years ago
I'm presuming this page needs updating:
https://developer.mozilla.org/en/NsISHistory
Keywords: dev-doc-needed

Updated

6 years ago
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 13

6 years ago
Thanks Trevor :-)
You need to log in before you can comment on or make changes to this bug.