Last Comment Bug 664979 - Merge nsISHistory_2_0_BRANCH into nsISHistory
: Merge nsISHistory_2_0_BRANCH into nsISHistory
Status: RESOLVED FIXED
[inbound]
: dev-doc-complete
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: 617539 665276
  Show dependency treegraph
 
Reported: 2011-06-17 05:27 PDT by Ed Morley [:emorley]
Modified: 2011-07-21 09:01 PDT (History)
5 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Merge nsISHistory_2_0_BRANCH (4.47 KB, patch)
2011-06-17 17:40 PDT, Ed Morley [:emorley]
bzbarsky: review+
Details | Diff | Review
Merge nsISHistory_2_0_BRANCH v1.1 (4.23 KB, patch)
2011-06-18 01:50 PDT, Ed Morley [:emorley]
emorley: review+
emorley: checkin+
Details | Diff | Review
Remove unnecessary QueryInterface call (1.21 KB, patch)
2011-06-19 05:23 PDT, Ed Morley [:emorley]
bzbarsky: review+
dholbert: checkin+
Details | Diff | Review

Comment 1 Ed Morley [:emorley] 2011-06-17 17:40:52 PDT
Created attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH

http://dev.philringnalda.com/tbpl/?tree=Try&rev=a03554955ed0

Thanks :-)
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-06-17 18:59:51 PDT
Comment on attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH

You don't need to change the history CID.  r=me with that change taken out.
Comment 3 Ed Morley [:emorley] 2011-06-18 01:50:02 PDT
Created attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1

Updated for review comments, carrying forwards r+.

For whomever checks this in, it has passed try (comment 1) and has author/commit message set already. Thanks! :-)
Comment 4 Ed Morley [:emorley] 2011-06-18 02:51:54 PDT
http://hg.mozilla.org/mozilla-central/rev/54cfcc5aeb7b
Comment 5 neil@parkwaycc.co.uk 2011-06-19 02:56:06 PDT
Comment on attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1

>         browser.webNavigation.sessionHistory.
>-          QueryInterface(Ci.nsISHistory_2_0_BRANCH).reloadCurrentEntry();
>+          QueryInterface(Ci.nsISHistory).reloadCurrentEntry();
sessionHistory is already nsISHistory, no need to call QueryInterface again.
Comment 6 Ed Morley [:emorley] 2011-06-19 05:23:02 PDT
Created attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

Removes unnecessary QueryInterface(Ci.nsISHistory) call, per comment 5.

Thanks for spotting that Neil :-)
Comment 7 Ed Morley [:emorley] 2011-06-20 09:26:07 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=0f7f8aa6e296
Comment 8 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-06-22 15:10:35 PDT
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

r=me
Comment 9 Ed Morley [:emorley] 2011-06-23 03:06:33 PDT
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call

Reopening so this shows on the checkin-needed searches.

Only the "Remove unnecessary QueryInterface call" patch is left to be landed - thanks! (Has passed try, see comment 7.
Comment 10 Daniel Holbert [:dholbert] (largely AFK until June 28) 2011-06-24 01:54:08 PDT
"Remove unnecessary QueryInterface call" patch landed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/484adb0cf79b
Comment 11 Marco Bonardo [::mak] 2011-06-25 03:11:39 PDT
http://hg.mozilla.org/mozilla-central/rev/484adb0cf79b
Comment 12 Ed Morley [:emorley] 2011-07-19 14:35:41 PDT
I'm presuming this page needs updating:
https://developer.mozilla.org/en/NsISHistory
Comment 13 Ed Morley [:emorley] 2011-07-21 09:01:20 PDT
Thanks Trevor :-)

Note You need to log in before you can comment on or make changes to this bug.