Closed Bug 665012 Opened 9 years ago Closed 9 years ago
Do not assume Get
Current Principal() == nsnull means system principal, in ns DOMData Transfer .cpp
Follow-up from bug 658037.
I will work on that unless someone wants to steal.
Assignee: nobody → mounir.lamouri
I've added a |nsresult& rv| method instead of the usual |nsresult* rv|. I don't see any advantage of using a pointer instead of a reference but only disadvantages. I believe I should use a pointer given that it's used everywhere but I might know why ;)
Attachment #540070 - Flags: review?(bzbarsky)
Comment on attachment 540070 [details] [diff] [review] Patch v1 >- NS_ENSURE_SUCCESS(rv, rv) >+ NS_ENSURE_SUCCESS(rv, rv); I assume this belongs in some other patch? The reason to use a pointer is that it makes it clearer at the callsite that an out param is being used (as opposed to in param). r=me modulo those issues.
Attachment #540070 - Flags: review?(bzbarsky) → review+
(In reply to comment #3) > The reason to use a pointer is that it makes it clearer at the callsite that > an out param is being used (as opposed to in param). > > r=me modulo those issues. I believe in "those issues" you include making rv a pointer instead of a reference?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.