665012 - Do not assume GetCurrentPrincipal() == nsnull means system principal, in nsDOMDataTransfer.cpp

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Mounir Lamouri (:mounir)]

Follow-up from bug 658037.

Comment 1

[Mounir Lamouri (:mounir)]

I will work on that unless someone wants to steal.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

I've added a |nsresult& rv| method instead of the usual |nsresult* rv|. I don't see any advantage of using a pointer instead of a reference but only disadvantages. I believe I should use a pointer given that it's used everywhere but I might know why ;)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 540070 [details] [diff] [review]
Patch v1

>-  NS_ENSURE_SUCCESS(rv, rv)
>+  NS_ENSURE_SUCCESS(rv, rv);

I assume this belongs in some other patch?

The reason to use a pointer is that it makes it clearer at the callsite that an out param is being used (as opposed to in param).

r=me modulo those issues.

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> The reason to use a pointer is that it makes it clearer at the callsite that
> an out param is being used (as opposed to in param).
> 
> r=me modulo those issues.

I believe in "those issues" you include making rv a pointer instead of a reference?

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/f6d7d57e7747