665034 - Signal errors from memcache

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Andy McKay]

Traceback (most recent call last):

 File "/data/amo_python/www/prod/zamboni/lib/safe_signals.py", line 29, in safe_send
   response = receiver(signal=self, sender=sender, **named)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 44, in post_save
   self.invalidate(instance)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 52, in invalidate
   invalidator.invalidate_keys(keys)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django-cache-machine/caching/invalidation.py", line 77, in invalidate_keys
   cache.set_many(dict((k, None) for k in flush), 5)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/cache/backends/memcached.py", line 120, in set_many
   self._cache.set_multi(safe_data, self._get_memcache_timeout(timeout))

 File "/data/amo_python/www/prod/zamboni/vendor/lib/python/memcache.py", line 632, in set_multi
   server_keys, prefixed_to_orig_key = self._map_and_prefix_keys(mapping.iterkeys(), key_prefix)

 File "/data/amo_python/www/prod/zamboni/vendor/lib/python/memcache.py", line 575, in _map_and_prefix_keys
   self.check_key(str_orig_key, key_extra_len=key_extra_len)

 File "/data/amo_python/www/prod/zamboni/vendor/lib/python/memcache.py", line 944, in check_key
   "Control characters not allowed")

MemcachedKeyCharacterError: Control characters not allowed

Comment 1

[Wil Clouser [:clouserw]]

We fixed this somewhere by md5ing the key.  Should do the same here, I guess

Comment 2

[Wil Clouser [:clouserw]]

I don't see these anymore - do you?  Possibly fixed with transition to pylibmc also.

Comment 3

[Andy McKay]

Haven't seen this in a long time.