branch filter worse than useless



Tree Management
6 years ago
3 years ago


(Reporter: mcote, Assigned: mcote)




(2 attachments)



6 years ago
Ever since we put a "tree" filter in the top-left, the "branch" filter (in the orange filter box) has had ambiguous meaning.  "branch", if provided, will trump "tree"; however, "branch" is only sent to the JSON APIs if it or any other orange-box filter is selected.  So you get very funny results if you, say, set the build type to "opt".  Now the calls to /bybug will have "branch=All", so the results will include all branches, regardless of the "tree" setting in the top left!  This results in *more* test runs being displayed in the filtered data than in the overall data, which is totally confusing.

Easy fix though: we'll completely remove the "branch" filter.  The selected branch will always be the top-left tree filter, both in overall and in filtered results.
Created attachment 540097 [details] [diff] [review] patch v0.1

This is an easy fix on the server side.
Attachment #540097 - Flags: review?(mcote)

Comment 2

6 years ago
Comment on attachment 540097 [details] [diff] [review] patch v0.1

Much better.
Attachment #540097 - Flags: review?(mcote) → review+

Comment 3

6 years ago
Created attachment 540115 [details] [diff] [review]
Remove branch filter

Client side.  Also simple.  I also increased the width of the QuickSearch and by ID filter text-entry boxes because it is now more noticeable that they are strangely short, compared to the width of the whole filter div.  They look okay here now; lemme know if it looks okay for you (it *shouldn't* wrap to a separate line from the filter-type dropdown).
Attachment #540115 - Flags: review?(jgriffin)
Comment on attachment 540115 [details] [diff] [review]
Remove branch filter

Looks good, and the new filter field widths look good also.
Attachment #540115 - Flags: review?(jgriffin) → review+

Comment 5

6 years ago
Pushed as
Server-side patch pushed as
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Testing → Tree Management
You need to log in before you can comment on or make changes to this bug.