665114 - Modal warning message for file deletion wrongly includes parent directories in its message

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

This is scary -- even though there isn't true data loss, the warning message is spurious.

STR:

1. Under Data, create a subfolder with another subfolder, like so:
Data
--> Foo/
----> Bar/
-------> Baz.js
2. Now, try to delete "Bar", and the prompt is "Are you sure you want to remove Foo/Bar and all its files?"

Expected Results:

It should only *say* "Are you sure you want to remove Bar and all its files?"

Comment 1

[Daniel Buchner [:dbuc]]

Additionally, when deleting directories that have no children, the modal message reads: Are you sure you want to remove "" <--- the directory name is not show, just a blank quoted string.

Comment 2

[Piotr Zalewa [:zalun]]

@stephend but it is the Foo/Bar which will be deleted

--> Foo/
----> Bar/
-------> Baz.js
--> Bar/

Then mesage "Are you sure you want to remove Bar and all its files?" would be ambiguous

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Perhaps wrap the "Foo/Bar" bit in <b> tags so that you can kinda see that it runs together?

Comment 4

[Daniel Buchner [:dbuc]]

No Stephen is right, when I choose to delete only subdirectory Bar, it should read "Bar and all or its files" and only delete Bar and anything Bar contains, Foo is the parent directory and has nothing to do with this request.

Comment 5

[Ryan N. Freebern [:rfreebern]]

I agree with @zalun that it could be ambiguous and confusing. Perhaps if the targeted subdirectory and its files were highlighted while the confirmation modal was displayed, to indicate explicitly which files and directories would be affected, then the ambiguity would be eliminated.

Comment 6

[Daniel Buchner [:dbuc]]

I just don't agree, take a look at any confirmation dialog in the OS, it just lists either the file or directory name when you try to delete. It is really odd to mention all the other parent directories that have nothing to do with it.

I would be up for having it say "Are you sure you want to remove Bar and all its files?" *and* do as rfreebern says and highlight the file or directory in question. Showing all the other directories above is not what a user is used to so I would like not to do that.

Comment 7

[Piotr Zalewa [:zalun]]

in review https://github.com/zalun/FlightDeck/commit/e53e36b41a7136d389c04b54e82e66618029401b

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.