mark read by date should use a filter enumerator

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Folder and Message Lists
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Bienvenu, Assigned: jyeo)

Tracking

({helpwanted})

unspecified
Thunderbird 11.0
x86
Windows 7
helpwanted

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently, the code that marks read by date iterates over all the headers in the db, from js, and checks each header to see if its date falls in the date range. 

http://mxr.mozilla.org/comm-central/source/mailnews/base/content/markByDate.js#124

It should use a filter enumerator with the date check in the enumerator, e.g., http://mxr.mozilla.org/comm-central/source/mailnews/db/msgdb/test/unit/test_filter_enumerator.js#52

This could massively cut down on the crossing of the js c++ boundary
(Reporter)

Comment 1

6 years ago
this is a very self-contained issue, and all js, and fairly simple.
Keywords: helpwanted
Whiteboard: [good first bug]
(Assignee)

Comment 2

6 years ago
Created attachment 576828 [details] [diff] [review]
665142#1.patch

I'm not sure if this solves the problem of minimizing the crossing over of js to c++. Please take a look and let me know the changes needed.
Assignee: nobody → jasonyeo88
Attachment #576828 - Flags: review?(dbienvenu)
(Reporter)

Comment 3

6 years ago
Comment on attachment 576828 [details] [diff] [review]
665142#1.patch

great job, Jason, yes this fixes the issue.
Attachment #576828 - Flags: review?(dbienvenu) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/b7656cc4ed04
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.