665275 - Cache of github issues page is consistently out of date until explicitly refreshed

Status: NEW

(Core :: Networking: Cache, defect, P3)

Description

[Josh Matthews [:jdm]]

This bug occurs like clockwork for me on nightlies.

STR:
1. go to https://github.com/graydon/rust/issues?sort=created&direction=desc&state=open
2. click on any issue
3. go back

Expected:
The same view as step 1 results (allowing for any changes that occurred whilst viewing the issue).

Actual:
The view is a cached one from the last time I visited the page.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> 3. go back

How?  If using the back button, the expectation is that the cached version will be shown on history navigations....

Comment 2

[Josh Matthews [:jdm]]

I use command+left brace on my mac, which is presumably the same action as the back button. I don't understand why the page I was just at wasn't cached, and I see the cached version from the previous day instead. Should I grab an nspr log of this?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I don't understand why the page I was just at wasn't cached, and I see the
> cached version from the previous day instead.

Oh, I see.  That sounds pretty broken, yes.

If you can reproduce reliably, an HTTP log would be interesting, yes.

Comment 4

[Josh Matthews [:jdm]]

Attachment: NSPR log of cache:5, nsHttp:5

Here's a big honkin' log starting from when I first go to the issues page. The relevant urls to help you find your bearings are https://github.com/graydon/rust/issues, https://github.com/graydon/rust/issues/536, and https://github.com/graydon/rust/issues?sort=created&direction=desc&state=open.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm.  So from HTTP's point of view, we just use "HTTP:https://github.com/graydon/rust/issues?sort=created&direction=desc&state=open" as a cache key, get a cache entry, and read it.

That's the first request for that URI in the log (which has VALIDATE_NEVER).  The second one has VALIDATE_ALWAYS and rereads from the server....

Comment 6

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 7

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258