Closed Bug 66529 Opened 24 years ago Closed 24 years ago

mkdepend builds break when interfaces change

Categories

(SeaMonkey :: UI Design, defect, P1)

Product:
SeaMonkey
Component:
UI Design
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.3

People

(Reporter: dbaron, Assigned: cls)

Details

Attachments

(5 files)

Generate deps on the fly if not using compiler generated deps
5.29 KB, patch
Details | Diff | Splinter Review
Updated on-the-fly mkdepend-based dep generation
6.00 KB, patch
Details | Diff | Splinter Review
Fix dependencies used to build in-tree mkdepend
1.09 KB, patch
Details | Diff | Splinter Review
Force use of in-tree mkdepend for solaris
510 bytes, patch
Details | Diff | Splinter Review
Add --disable-auto-deps config option
9.06 KB, patch
Details | Diff | Splinter Review
Since the checkins by mscott and timeless, the HPUX 10.20 tinderbox (como) and the IRIX tinderbox (cement) have been crashing on startup in the alive test: http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey-Ports Changes that could have caused this are the following (I double-checked the first failing tinderbox log to make sure exactly these changes were pulled): http://bonsai.mozilla.org/cvsquery.cgi?module=SeaMonkeyAll&date=explicit&mindate=980403660&maxdate=980405459
None of my code is executed until the user clicks on link which requires an external handler (with the open/save to disk dialog). This is not part of the automated smoketests. timeless?
can you get me a stack trace? and can force them to use the 1.10 version of mozilla/ xpfe/ global/ resources/ content/ dialogOverlay.js it doesn't make sense that my changes would cause this. Asking brendan for help :-(. I know he had some jseng work backed out recently, and my changes are to .js code
Assignee: mscott → timeless
Status: NEW → ASSIGNED
Component: Browser-General → XP Apps
Keywords: crash, stackneeded
Priority: -- → P1
QA Contact: doronr → sairuh
Oh sure, blame me. ;-) My change did not add a crash bug, AFAIK. It just busted for(var i in o); loops something fierce. /be
adding qawanted, until i can get my O2 upgraded and/or behaving... :(
Keywords: qawanted
Backing out the changes using the url from the first bug entry made the problem go away on Irix. Reapplying timeless' change to dialogOverlay.js did not cause the problem to reappear. Irix dbx and I have never been friends so it may be a bit before I can cajole it into giving me a trace.
Assignee: timeless → mscott
Status: ASSIGNED → NEW
Severity: critical → blocker
/usr/bin/dbx ./mozilla-bin core dbx version 7.2.1.3m Dec 23 1998 01:09:37 Core from signal SIGSEGV: Segmentation violation (dbx) where > 0 nsExternalHelperAppService::GetTypeFromFile(nsIFile*,char**)(this = 0x10175f00, aFile = 0x10177d10, aContentType = 0x7ffef390) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/uriloader/exthandler/nsExt ernalHelperAppService.cpp":1263, 0x5367174] 1 nsExternalHelperAppService::GetTypeFromFile(nsIFile*,char**)(this = 0x10175f00, aFile = 0x10175cc8, aContentType = 0x7ffef390) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/uriloader/exthandler/nsExt ernalHelperAppService.cpp":1301, 0x5367348] 2 nsFileChannel::GetContentType(char**)(this = 0x10097540, aContentType = 0x7ffef390) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/netwerk/protocol/file/src/ nsFileChannel.cpp":436, 0x4ff831c] 3 nsParser::OnStartRequest(nsIChannel*,nsISupports*)(this = 0x10097c50, channel = 0x10097540, aContext = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/htmlparser/src/nsParser.cp p":2096, 0x63c7408] 4 RDFXMLDataSourceImpl::OnStartRequest(nsIChannel*,nsISupports*)(this = 0x10094f88, channel = 0x10097540, ctxt = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/base/src/nsRDFXMLDataS ource.cpp":1087, 0x4bb5c68] 5 ::rdf_BlockingParse(nsIURI*,nsIStreamListener*)(aURL = 0x10095dc0, aConsumer = 0x10094f98) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/base/src/nsRDFXMLDataS ource.cpp":621, 0x4babf38] 6 RDFXMLDataSourceImpl::Refresh(int)(this = 0x10094f88, aBlocking = 1) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/base/src/nsRDFXMLDataS ource.cpp":948, 0x4bb4994] More (n if no)?y 7 nsChromeRegistry::LoadDataSource(const nsCString&,nsIRDFDataSource**,int,const char*)(this = 0x10094a70, aFileName = 0x7ffefd40, aResult = 0x7ffefd38, aUseProfileDir = 0, aProfilePath = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/src/nsChromeReg istry.cpp":932, 0x62d2514] 8 nsChromeRegistry::AddToCompositeDataSource(int)(this = 0x10094a70, aUseProfile = 0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/src/nsChromeReg istry.cpp":2325, 0x62d6e64] 9 nsChromeRegistry::CheckForNewChrome(void)(this = 0x10094a70) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/src/nsChromeReg istry.cpp":2561, 0x62cb928] 10 nsChromeRegistry::Init(void)(this = 0x10094a70) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/src/nsChromeReg istry.cpp":329, 0x62cd8e4] 11 ::nsChromeRegistryConstructor(nsISupports*,const nsID&,void**)(aOuter = (nil), aIID = 0x41f4a90, aResult = 0x7fff020c) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/build/nsChromeF actory.cpp":36, 0x62bd558] 12 nsGenericFactory::CreateInstance(nsISupports*,const nsID&,void**)(this = 0x10093ac8, aOuter = (nil), aIID = 0x41f4a90, aResult = 0x7fff020c) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsGeneric Factory.cpp":47, 0x41253bc] 13 nsComponentManagerImpl::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(this = 0x1002dd30, aClass = 0x630d820, aDelegate = (nil), aIID = 0x41f4a90, aResult = 0x7fff020c) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.cpp":1201 More (n if no)? , 0x4118804] 14 nsComponentManager::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(aClass = 0x630d820, aDelegate = (nil), aIID = 0x41f4a90, aResult = 0x7fff020c) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsReposit ory.cpp":81, 0x413879c] 15 nsServiceManagerImpl::GetService(const nsID&,const nsID&,nsISupports**,nsIShutdownListener*)(this = 0x1002d2e8, aClass = 0x630d820, aIID = 0x41f4a90, result = 0x7fff02f0, shutdownListener = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":344, 0x413c9fc] 16 nsServiceManager::GetService(const nsID&,const nsID&,nsISupports**,nsIShutdownListener*)(aClass = 0x630d820, aIID = 0x41f4a90, result = 0x7fff02f0, shutdownListener = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":559, 0x4139e2c] 17 nsGetServiceByCID::operator()(const nsID&,void**) const(this = 0x7fff0358, aIID = 0x41f4a90, aInstancePtr = 0x7fff02f0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":44, 0x413a5e8] 18 nsCOMPtr_base::assign_from_helper(const nsCOMPtr_helper&,const nsID&)(this = 0x7fff0370, helper = 0x7fff0358, iid = 0x41f4a90) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/base/nsCOMPtr.cpp":6 5, 0x40620fc] 19 nsCOMPtr<nsIChromeRegistry>::nsCOMPtr<nsIChromeRegistry>(const nsCOMPtr_helper&)(this = 0x7fff0370, helper = 0x7fff0358) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsCOMPtr.h":551, 0x62f98c4] More (n if no)? 20 nsChromeProtocolHandler::NewChannel(nsIURI*,nsIChannel**)(this = 0x10093a88, aURI = 0x10094a18, aResult = 0x7fff0630) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/rdf/chrome/src/nsChromePro tocolHandler.cpp":656, 0x62f3bb8] 21 nsIOService::NewChannelFromURI(nsIURI*,nsIChannel**)(this = 0x100b2e40, aURI = 0x10094a18, result = 0x7fff0630) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/netwerk/base/src/nsIOServi ce.cpp":295, 0x4e78094] 22 ::NS_OpenURI(nsIChannel**,nsIURI*,nsIIOService*,nsILoadGroup*,nsIInterfaceReques tor*,unsigned int,unsigned int,unsigned int)(result = 0x7fff06a0, uri = 0x10094a18, ioService = 0x100b2e40, loadGroup = (nil), notificationCallbacks = (nil), loadAttributes = 0, bufferSegmentSize = 0, bufferMaxSize = 0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsNetUtil.h":111, 0x6280360] 23 ::NS_OpenURI(nsIInputStream**,nsIURI*,nsIIOService*,nsILoadGroup*,nsIInterfaceRe questor*,unsigned int,unsigned int,unsigned int)(result = 0x7fff0850, uri = 0x10094a18, ioService = (nil), loadGroup = (nil), notificationCallbacks = (nil), loadAttributes = 0, bufferSegmentSize = 0, bufferMaxSize = 0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsNetUtil.h":158, 0x628073c] 24 nsStringBundle::OpenInputStream(nsString&,nsIInputStream*&)(this = 0x100922f0, aURLStr = 0x7fff0778, in = 0x7fff0850) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/intl/strres/src/nsStringBu ndle.cpp":492, 0x6286480] 25 nsStringBundle::GetInputStream(const char*,nsILocale*,nsIInputStream*&)(this = 0x100922f0, aURLSpec = 0x100943e8 = "chrome://navigator/locale/navigator.properties" More (n if no)? , aLocale = (nil), in = 0x7fff0850) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/intl/strres/src/nsStringBu ndle.cpp":473, 0x6286398] 26 nsStringBundle::InitSyncStream(const char*)(this = 0x100922f0, aURLSpec = 0x100943e8 = "chrome://navigator/locale/navigator.properties") ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/intl/strres/src/nsStringBu ndle.cpp":121, 0x62849b8] 27 nsStringBundleService::getStringBundle(const char*,int,nsIStringBundle**)(this = 0x100945f0, aURLSpec = 0x100943e8 = "chrome://navigator/locale/navigator.properties", async = 0, aResult = 0x7fff0968) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/intl/strres/src/nsStringBu ndle.cpp":943, 0x628b194] 28 nsStringBundleService::CreateBundle(const char*,nsILocale*,nsIStringBundle**)(this = 0x100945f0, aURLSpec = 0x100943e8 = "chrome://navigator/locale/navigator.properties", aLocale = (nil), aResult = 0x7fff0968) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/intl/strres/src/nsStringBu ndle.cpp":1033, 0x628a544] 29 nsPref::GetDefaultLocalizedUnicharPref(const char*,unsigned short**)(this = 0x10055ce8, pref = 0x507d408 = "general.useragent.locale", return_buf = 0x7fff0b28) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/modules/libpref/src/nsPref .cpp":1019, 0x4a28b30] 30 nsPref::GetLocalizedUnicharPref(const char*,unsigned short**)(this = 0x10055ce8, pref = 0x507d408 = "general.useragent.locale", return_buf = 0x7fff0b28) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/modules/libpref/src/nsPref .cpp":1000, 0x4a28880] More (n if no)? 31 nsHTTPHandler::InitUserAgentComponents(void)(this = 0x100940a8) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/netwerk/protocol/http/src/ nsHTTPHandler.cpp":682, 0x4fa6b58] 32 nsHTTPHandler::Init(void)(this = 0x100940a8) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/netwerk/protocol/http/src/ nsHTTPHandler.cpp":770, 0x4fa191c] 33 ::nsHTTPHandlerConstructor(nsISupports*,const nsID&,void**)(aOuter = (nil), aIID = 0x10021d50, aResult = 0x7fff1bcc) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/netwerk/build/nsNetModule. cpp":102, 0x4e62f18] 34 nsGenericFactory::CreateInstance(nsISupports*,const nsID&,void**)(this = 0x100938c8, aOuter = (nil), aIID = 0x10021d50, aResult = 0x7fff1bcc) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsGeneric Factory.cpp":47, 0x41253bc] 35 nsComponentManagerImpl::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(this = 0x1002dd30, aClass = 0x5f41e08, aDelegate = (nil), aIID = 0x10021d50, aResult = 0x7fff1bcc) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.cpp":1201, 0x4118804] 36 nsComponentManager::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(aClass = 0x5f41e08, aDelegate = (nil), aIID = 0x10021d50, aResult = 0x7fff1bcc) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsReposit ory.cpp":81, 0x413879c] 37 nsServiceManagerImpl::GetService(const nsID&,const nsID&,nsISupports**,nsIShutdownListener*)(this = 0x1002d2e8, aClass = 0x5f41e08, aIID = 0x10021d50, result More (n if no)? = 0x7fff1cb0, shutdownListener = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":344, 0x413c9fc] 38 nsServiceManager::GetService(const nsID&,const nsID&,nsISupports**,nsIShutdownListener*)(aClass = 0x5f41e08, aIID = 0x10021d50, result = 0x7fff1cb0, shutdownListener = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":559, 0x4139e2c] 39 nsGetServiceByCID::operator()(const nsID&,void**) const(this = 0x7fff1d48, aIID = 0x10021d50, aInstancePtr = 0x7fff1cb0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsService Manager.cpp":44, 0x413a5e8] 40 nsCOMPtr_base::assign_from_helper(const nsCOMPtr_helper&,const nsID&)(this = 0x7fff1d58, helper = 0x7fff1d48, iid = 0x10021d50) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/base/nsCOMPtr.cpp":6 5, 0x40620fc] 41 nsCOMPtr<nsIHTTPProtocolHandler>::nsCOMPtr<nsIHTTPProtocolHandler>(const nsCOMPtr_helper&)(this = 0x7fff1d58, helper = 0x7fff1d48) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsCOMPtr.h":551, 0x562c814] 42 nsLayoutModule::SetUserAgent(void)(this = 0x100ff4b0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/layout/build/nsLayoutModul e.cpp":483, 0x562c49c] 43 nsLayoutModule::Initialize(void)(this = 0x100ff4b0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/layout/build/nsLayoutModul e.cpp":242, 0x562c1d0] More (n if no)? 44 nsLayoutModule::GetClassObject(nsIComponentManager*,const nsID&,const nsID&,void**)(this = 0x100ff4b0, aCompMgr = 0x1002dd30, aClass = 0x100d7490, aIID = 0x41e3450, r_classObj = 0x7fff2430) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/layout/build/nsLayoutModul e.cpp":305, 0x562bb84] 45 nsNativeComponentLoader::GetFactoryFromModule(nsDll*,const nsID&,nsIFactory**)(this = 0x10031210, aDll = 0x1004efc0, aCID = 0x100d7490, aFactory = 0x7fff2430) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsNativeC omponentLoader.cpp":1172, 0x412e874] 46 nsNativeComponentLoader::GetFactory(const nsID&,const char*,const char*,nsIFactory**)(this = 0x10031210, aCID = 0x100d7490, aLocation = 0x100d6c80 = "rel:libgklayout.so", aType = 0x100d5240 = "application/x-mozilla-native", _retval = 0x7fff2430) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsNativeC omponentLoader.cpp":136, 0x412a97c] 47 nsFactoryEntry::GetFactory(nsIFactory**,nsComponentManagerImpl*)(this = 0x100d7490, aFactory = 0x7fff2430, mgr = 0x1002dd30) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.h":217, 0x4120824] 48 nsComponentManagerImpl::FindFactory(const nsID&,nsIFactory**)(this = 0x1002dd30, aClass = 0x5fef1e98, aFactory = 0x7fff2430) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.cpp":1030, 0x4117f84] 49 nsComponentManagerImpl::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(this = 0x1002dd30, aClass = 0x5fef1e98, aDelegate = (nil), aIID = 0x5ff0b308, aResult = 0x7fff2510) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.cpp":1198 More (n if no)? , 0x41187b4] 50 nsComponentManager::CreateInstance(const nsID&,nsISupports*,const nsID&,void**)(aClass = 0x5fef1e98, aDelegate = (nil), aIID = 0x5ff0b308, aResult = 0x7fff2510) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsReposit ory.cpp":81, 0x413879c] 51 nsCreateInstanceByCID::operator()(const nsID&,void**) const(this = 0x7fff2570, aIID = 0x5ff0b308, aInstancePtr = 0x7fff2510) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/components/nsCompone ntManager.cpp":133, 0x4112550] 52 nsCOMPtr_base::assign_from_helper(const nsCOMPtr_helper&,const nsID&)(this = 0x100cbb18, helper = 0x7fff2570, iid = 0x5ff0b308) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/base/nsCOMPtr.cpp":6 5, 0x40620fc] 53 nsCOMPtr<nsIEventListenerManager>::operator=(const nsCOMPtr_helper&)(this = 0x100cbb18, rhs = 0x7fff2570) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsCOMPtr.h":601, 0x5fdef980] 54 nsWindowRoot::GetListenerManager(nsIEventListenerManager**)(this = 0x100cbb00, aResult = 0x7fff25b0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/dom/src/base/nsWindowRoot. cpp":141, 0x5fdf1488] 55 nsWindowRoot::AddEventListener(const basic_nsAReadableString<unsigned short>&,nsIDOMEventListener*,int)(this = 0x100cbb00, aType = 0x7fff2638, aListener = 0x101007d4, aUseCapture = 1) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/dom/src/base/nsWindowRoot. cpp":62, 0x5fdf0668] More (n if no)? 56 nsWindowRoot::nsWindowRoot(nsIDOMWindow*)(this = 0x100cbb00, aWindow = 0x101006d4) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/dom/src/base/nsWindowRoot. cpp":48, 0x5fdefff0] 57 ::NS_NewWindowRoot(nsIDOMWindow*,nsIChromeEventHandler**)(aWindow = 0x101006d4, aResult = 0x101007b4) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/dom/src/base/nsWindowRoot. cpp":224, 0x5fdeef84] 58 GlobalWindowImpl::SetDocShell(nsIDocShell*)(this = 0x101006d0, aDocShell = 0x100fed68) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/dom/src/base/nsGlobalWindo w.cpp":465, 0x5fd8ec00] 59 nsDocShell::EnsureScriptEnvironment(void)(this = 0x100fed68) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/docshell/base/nsDocShell.c pp":4378, 0x52cca90] 60 nsWebShell::GetInterface(const nsID&,void**)(this = 0x100fed68, aIID = 0x10022110, aInstancePtr = 0x7fff29f0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/docshell/base/nsWebShell.c pp":329, 0x52df948] 61 nsGetInterface::operator()(const nsID&,void**) const(this = 0x7fff2a70, aIID = 0x10022110, aInstancePtr = 0x7fff29f0) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/base/nsIInterfaceReq uestor.cpp":37, 0x4183df4] 62 nsCOMPtr_base::assign_from_helper(const nsCOMPtr_helper&,const nsID&)(this = 0x7fff2a80, helper = 0x7fff2a70, iid = 0x10022110) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpcom/base/nsCOMPtr.cpp":6 5, 0x40620fc] 63 nsCOMPtr<nsIDOMWindowInternal>::nsCOMPtr<nsIDOMWindowInternal>(const nsCOMPtr_helper&)(this = 0x7fff2a80, helper = 0x7fff2a70) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/obj-mips-sgi-irix6.5/dist/ include/nsCOMPtr.h":551 More (n if no)? , 0x459b334] 64 nsAppShellService::GetHiddenWindowAndJSContext(nsIDOMWindowInternal**,JSContext* *)(this = 0x10087a98, aWindow = 0x7fff2b38, aJSContext = 0x7fff2b50) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpfe/appshell/src/nsAppShe llService.cpp":723, 0x459f554] 65 nsAppShellService::SetXPConnectSafeContext(void)(this = 0x10087a98) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpfe/appshell/src/nsAppShe llService.cpp":191, 0x45a158c] 66 nsAppShellService::CreateHiddenWindow(void)(this = 0x10087a98) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpfe/appshell/src/nsAppShe llService.cpp":247, 0x459ef60] 67 ::main1(int,char**,nsISupports*)(argc = 1, argv = 0x7fff2f24, nativeApp = (nil)) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpfe/bootstrap/nsAppRunner .cpp":951, 0x1000c718] 68 ::main(argc = 1, argv = 0x7fff2f24) ["/export/tinderbox/SeaMonkey/IRIX_6.5_Depend/mozilla/xpfe/bootstrap/nsAppRunner .cpp":1272, 0x1000da24] 69 __start() ["/xlv55/kudzu-apr12/work/irix/lib/libc/libc_n32_M3/csu/crt1text.s":177, 0x10006d28] (dbx)
Keywords: stackneeded → smoketest
thanks for the stack trace Chris. If the line numbers are to be trusted we are crashing when attempting to get a LeafName from the argument aFile: rv = aFile->GetLeafName(&fileName); But aFile isn't null. None of this code has changed in a long time. However I did add two new methods to this class. Any chance it's a dependency problem?
Keywords: smoketest → stackneeded
Ok, it turns out that mscott is right. It is a dependency problem of some sort as clobbering uriloader "fixed" the problem. (It also causes most of the app to recompiled.) Reassigning to myself to find & fix the dependency problem.
Assignee: mscott → cls
Severity: blocker → critical
Keywords: crash, qawanted, stackneeded
i don't know why HPUX has such a horrible dependency problem with this directory. ended up backing out my original checkin so I could move the functionality to nsILocalFile instead. we just need someone to clobber the uriloader\exthandler directory on the tinderbox machine again.
Ok, so I changed the tinderbox to clobber instead of depend... Sorry for the problems this caused.
Changing the summary to reflect the actual problem. I think the dependency problem comes from a combination of using makedepend to generate the deps and from changing interfaces (.idl).
Keywords: qawanted
Priority: P1 → P2
QA Contact: sairuh → granrose
Summary: IRIX and HPUX tinderboxes crashing on startup of tests → IRIX and HPUX deps break when interfaces change
Target Milestone: --- → mozilla1.0
The problem appears to lie somewhere between "we're running depend at the wrong place" and "generated headers + 2 pass builds just inherently suck". If I run |make depend| using mkdepend on a fresh tree, mkdepend complains about not finding the proper header files. If I run |make depend| after running |make export|, then the right dependencies are found. So it seems that mkdepend builds would always be a cycle behind as far as the dependency file goes. I added a dummy function to nsIExternalProtocolService.idl Build runs |make depend|: gcc -MD) Build does nothing. mkdepend) Build dependencies are updated in depend.mk based upon existing (soon-to-be outdated) headers. Build runs |make export|: all) nsIExternalProtocalService.h is generated Build runs |make install|: gcc -MD) rebuilds: nsExternalHelperAppService.o nsExternalProtocolHandler.o nsOSHelperAppService.o nsURILoaderModule.o nsDocShell.o mkdepend) rebuilds: nsExternalHelperAppService.o nsExternalProtocolHandler.o nsURILoaderModule.o nsDocShell.o Erk. That wasn't the result I was expecting. Removing the /dev/null redirect of makedepend output gives us this: /usr/X11R6/bin/makedepend: warning: cannot open "../../../mozilla/uriloader/exthandler/nsOSHelperAppService.cpp" So the problem in this particular situation is that a) we have multiple directories in our VPATH in uriloader/exthandler/Makefile.in or b) our mkdepend rule isn't fully VPATH aware. Take your pick. gcc handles this situation just fine as it recomputes dependencies as it compiles the file. I'm thinking that this isn't such a bad idea for all compilers. Just do away with the depend stage and generate a %.d dep file whenever we compile a file.
OS: IRIX → All
Priority: P2 → P1
Hardware: SGI → All
Summary: IRIX and HPUX deps break when interfaces change → mkdepend builds break when interfaces change
When I was at SGI, I added a -MDupdate option to SGI's compilers and linker that did the record-dependencies-as-we-go thang. It even incrementally updated a common .deps file, with file locking, so you didn't need a .d or .pp file per source file. Mebbe that can be used on IRIX still? /be
Oh, crap. Ignore that patch. It still runs mkdepend in the wrong place (during the export pass and before the export targets have been built). I didn't notice it until I did a clobber build & the previous idl change test.
This patch replaces the |make depend| build pass with an "integrated" dependency generator. We only use it if the compiler doesn't have its own dependency generator. Dependencies are regenerated whenever the file is compiled. This is basically what -MD does. This patch fixes the problem I saw when using multiple VPATHS. Since we'd run a separate makedepend for each source file, we also avoid the problem listed in the makedepend manpage wrt parsing files once. On my work box (dual xeon-800, uw-80 scsi, make -j1), I'm only seeing a +5 min difference between between the gcc -MD build and the new makedepend build. I'm going to venture that killing the need for a separate |make depend| pass will be a win for our slower tinderboxes as well but I can't back that up atm. Brendan, we could probably use non-gcc -MD flags. We'd just need to find out what they are for each compiler and update _DEPEND_CFLAGS & maybe some COMPILER_DEPEND ifdefs accordingly. This patch should be the LCD fix though.
r=leaf on patch 29440
Patch has been checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reopening. I've gotten reports that the fix is causing the build times on solaris to double when using Workshop. Tor has mentioned that sun had a fairly broken system makedepend binary until a recent solaris release (8, maybe?). I did verify that building gfx/src/gtk was much smaller when using the in tree version of mkdepend but I haven't done a full tree yet. gmake -C gfx/src/gtk MKDEPEND=: 2 min gmake -C gfx/src/gtk MKDEPEND=/usr/X11/bin/makedepend 9 min gmake -C gfx/src/gtk MKDEPEND=/moz/config/mkdepend 4 min
Status: RESOLVED → REOPENED
Keywords: mozilla0.9
Resolution: FIXED → ---
Target Milestone: mozilla1.0 → mozilla0.9
If this is really Sun's "makedepend" fault them I suggest _not_ to fix this on Mozilla's side, this can easily be handeled by fixing "makedepend" on Sun's side. CC'ing someone from Sun (rich.burridge@Sun.COM) who may be able to handle this...
Well, my proposed fix was going to be just force solaris to use the in-tree makedepend for 0.9. Post 0.9, we can determine the proper fix and try to addd the WS compiler dependency option. Right now, I'm still waiting for my timed builds to finish.
What about simply letting Sun fix that issue ? AFAIK it works technically _correct_, right ? Maybe a good chanche to get the broken imake/makedepend stuff on Solaris fixed because Mozilla is not the only application which suffers from these bugs. Trying to workaround such problems isn't always a good idea... and Sun has "active development" of bugfixes for their Solaris releases - whys not using this way instead of "hack around it" ?
Because Sun's not going to get this problem fixed _and_ deployed to the majority of their users by the time we are going to want to release 0.9. Using our fallback copy of mkdepend is not going to prevent Sun from producing an official fix. It will just stop our developers from hurting in the meantime.
cls: Agreed. 1. What about adding the comment that this is a workaround until Sun fixes this ? 2. What about turning this off for Solaris >= 2.8 (assuming that Solaris >= 2.8 have "fixed" makedepend binaries) ?
Are you still shooting for 0.9 on this? If so please email drivers@mozilla.org with a status on you progress. If not please retarget against a later Milestone. Thanks.
r=pavlov
a=tor for 0.9 checkin
Patches have been checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Just to quote it: A simple small % configure --with-xprint --enable-mathml --enable-svg --enable-xsl --enable-optimize % make took 1353m50.917s compared to 4-5 hours without this bug... grrr... ;-((
This breaks HP's commercial build. running gmake -f client.mk build_all from the 'ns' tree eventually grabs ../mozilla/config/rules.mk and tries to do gmake -C ./config nsinstall which fails
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Is this *really* a mozilla build system bug, and not a bug in the ns/ build system?
Same problem here on the Solaris platform: gmake gmake -C ./config nsinstall gmake[1]: Entering directory `/export3/builds/forte/5.7/sparc/mtchan042501/ns/config' gmake[1]: *** No rule to make target `nsinstall'. Stop. gmake[1]: Leaving directory `/export3/builds/forte/5.7/sparc/mtchan042501/ns/config' gmake: *** [config/mkdepend/mkdepend] Error 2
Not sure how I would classify this bug. I think it is easier to 'fix' it via the mozilla tree since to change it on the other side (ns) I think we have to redo LOTS of things. one fix is to hack put in $(DEPTH)/../mozilla/config to replace $(DEPTH)/config (rules.mk & config.mk) but this is kinda kludgey NOTE: you can reproduce this on Linux but modifying mozilla/config/autoconf.mk and unsetting the 'NATIVE_DEPEND' line (/usr/bin/X11/mkdepend) and COMPILER_DEPEND = line
Try this patch: Index: config/config.mk =================================================================== RCS file: /cvsroot/mozilla/config/config.mk,v retrieving revision 3.186 diff -u -r3.186 config.mk --- config.mk 2001/04/24 03:54:12 3.186 +++ config.mk 2001/04/26 03:49:55 @@ -409,7 +409,7 @@ MKDEPEND_DIR = MKDEPEND = $(MOZ_NATIVE_MAKEDEPEND) else -MKDEPEND_DIR = $(DEPTH)/config/mkdepend +MKDEPEND_DIR = $(CONFIG_TOOLS)/mkdepend MKDEPEND = $(MKDEPEND_DIR)/mkdepend ifndef COMPILER_DEPEND ifneq ($(OS_ARCH),OS2)
Status: REOPENED → ASSIGNED
This diff works for me... can you check this in?
Works fine with Solaris Sparc as well. Margaret
Patch has been checked into the trunk. Submitted request to drivers for 0.9 branch.
How do I turn off all make depend builds? We found that while the mozilla tree (on HP) doesn't take that much longer, building the commercial tree takes nearly twice as long. I tried turning on HP's compiler make depend flag (but they only have one for the c++ compiler and not 'cc' and that doesn't work quite right). So how do I turn off make depend altogether. --disable-md doesn't seem to do it.
If you going to do clobbers and only clobbers, set mk_add_options MKDEPEND=: in your .mozconfig. However, if you do this, then don't try to use the same tree for a depend build as the dependencies would not have been set. And running 'make depend' won't update them. Not sure how to get around that little problem short of force 'make depend' to always run mkdepend (bad for tbs) or add a 'make force_depend' stage. I don't want to make this a toplevel configure option as in general, not generating dependencies when compiling is bad, right?
We planned to try mk_add_options MKDEPEND=: in our commercial build to see how much time it will save us for clobber build. However, our commercial build keep failing for various reasons. We'll have to get a clean build before we can get any numbers.
It is possible to adopt the check for Solaris a little bit that any version beyond 2.7 (e.g. 2.8, 2.9, etc.) or in a non-standard location (e.g. != "/usr/openwin/bin/makedepend") will use the binary in $PATH again - assuming Solaris >= 2.8 shippes with a fixed makedepend version...
SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building. please update the target milestone so we can get a good idea of what's left for 0.9.1.
Target Milestone: mozilla0.9 → mozilla0.9.3
Ok, I caved. --disable-auto-deps causes the build system to not generate dependencies on the fly which should benefit some clobber-only builds greatly. It also partially resurrects the old depend target so you can still do |make depend| to convert a clobber build to a dep build. It also fixes the VPATH problem we had earlier with the old depend system.
r=pavlov
Patch has been checked in. Marking fixed (hopefully for the last time) :-P.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: