665324 - Page Info - Security Tab - Text Alignment is off

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Teddy Ni]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110618 Firefox/7.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110618 Firefox/7.0a1

The bold text is not aligned correctly with its corresponding label in the Security tab of Page Info.

Reproducible: Always

Steps to Reproduce:
1. Open Page Info dialog.
2. Go to Security tab.

Comment 1

[Teddy Ni]

Attachment: aligns correctly on Windows

The changes in the patch seem to work in my Windows install. Similar changes may need to be done in the other pageInfo.css files in the themes folder, but since I don't have those themes running, I won't touch them.

Comment 2

[Tim (fmdeveloper)]

Can you attach a screenshot showing the issue?

Comment 3

[Teddy Ni]

Attachment: screenshot of before patch on Windows

This image shows what I was seeing on my FF5, but it was having the same alignment issue on Nightly. The bold text is just a few pixels underneath the label text.

Comment 4

[Tim (fmdeveloper)]

Confirmed on Mozilla/5.0 (Windows NT 5.1; rv:7.0a1) Gecko/20110619 Firefox/7.0a1 ID:20110619030732

STR:

Go to https://hg.mozilla.org/projects
Open Page Info from Tools menu
Click on Security tab
Alignment of text to labels is off (i.e. "Have I saved passwords for this web site?" is not lined up with the value "No")

Comment 5

[Aaron Raimist [:aaronraimist]]

Attachment: bug665324_textalignment.diff

Could I be assigned to this bug?

Comment 6

[Aaron Raimist [:aaronraimist]]

Attachment: Screenshot after patch (Mac)

Comment 7

[Brian R. Bondy [:bbondy]]

Comment on attachment 8557646 [details] [diff] [review]
bug665324_textalignment.diff

Review of attachment 8557646 [details] [diff] [review]:
-----------------------------------------------------------------

Forwarding to another browser peer.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8557646 [details] [diff] [review]
bug665324_textalignment.diff

Review of attachment 8557646 [details] [diff] [review]:
-----------------------------------------------------------------

Nice job on your first patch. Just one minor change that we can make to the three files and it will be ready for check-in.

You can make the changes, update the patch summary to include "r=jaws" at the end, then upload the new patch and add the "checkin-needed" keyword to the bug.

::: browser/themes/windows/pageInfo.css
@@ +253,5 @@
>  }
>  
>  #securityPanel .fieldValue {
>    font-weight: bold;
> +  margin: 2px 10px 3px 10px;

Please use the shorthand here and for the other files:
margin: 2px 10px 3px;

Comment 9

[Aaron Raimist [:aaronraimist]]

Attachment: bug665324_textalignment_v2.diff

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/f160039ee91e

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f160039ee91e

Comment 12

[[e-mail]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0 Its fixed in my case

Comment 13

[Md. Ehsanul Hassan]

I have reproduced this bug on Firefox nightly 7.0a1 (2011-06-18) on windows 8.1 (64bit).

this bug is verified as fixed .
Latest Firefox nightly 48.0a1 
Build Id:  	20160325030241
user Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

[bugday-20160427]