Reference to *English* despite language change in the continue button

VERIFIED FIXED in Firefox 7

Status

VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: aaronmt, Assigned: wesj)

Tracking

Trunk
Firefox 7
ARM
Android
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110620 Firefox/7.0a1 Fennec/7.0a1

This doesn't seem right. Each language one selects from the locale picker has an odd problem. The "Continue in *language*" button will refer to "English", either in English itself (non translated) or the selected language refers to English instead of referencing to the language selected.


ER: Selecting Français: "Continuer in Français".
AR: Selecting Français: "Continuer en Anglais".

or

ER: Selecting Italiano: "Continua in Italiano".
AR: Selecting Italiano: "Continua in Inglese".

STR:
1. Start Nightly
2. Choose a different language
3. Select Français

"Continuer en Anglais"

Or.

3. Select Deutsch

"Continue in English"

Or.

3. Select Italiano

"Continua in Inglese"
Dupe of bug 665507?
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> Dupe of bug 665507?

Looks like that one is reffering to the non-translation, where this one is focusing on the reference to English instead of the selected language.
(Reporter)

Updated

7 years ago
Summary: Continue in *English* despite language change → Reference to *English* despite language change in the continue button
(Assignee)

Updated

7 years ago
Depends on: 665583
(Assignee)

Updated

7 years ago
Depends on: 665584
(Assignee)

Updated

7 years ago
Depends on: 665585
(Assignee)

Updated

7 years ago
Depends on: 665587
(Assignee)

Updated

7 years ago
Depends on: 665588
(Assignee)

Updated

7 years ago
Depends on: 665589
(Assignee)

Updated

7 years ago
Depends on: 665590
(Assignee)

Updated

7 years ago
Depends on: 665591
(Assignee)

Updated

7 years ago
Depends on: 665592
(Assignee)

Updated

7 years ago
Depends on: 665593
(Assignee)

Comment 3

7 years ago
Created attachment 540533 [details]
Patch

This just adds a comment for localizers. Also removes an unused string.
Assignee: nobody → wjohnston
Attachment #540533 - Flags: review?(mark.finkle)
Comment on attachment 540533 [details]
Patch

>diff --git a/mobile/locales/en-US/chrome/localepicker.properties b/mobile/locales/en-US/chrome/localepicker.properties

>+
>+# The localized name of this locale

# LOCALIZATION NOTE (localeName): The localized name of this locale. Do not just translate the word 'English'

> name=English

I think you'll need to change the entity name so the localizers know they need to change this.

name -> localeName
Attachment #540533 - Flags: review?(mark.finkle) → review+
(In reply to comment #4)

> I think you'll need to change the entity name so the localizers know they
> need to change this.
> 
> name -> localeName

FTR, we don't need the entity change. We'll file bugs on the locales that got it wrong
(Assignee)

Updated

7 years ago
Depends on: 665634
(Assignee)

Updated

7 years ago
Whiteboard: [inbound]

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/557b0b1ebfe6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7

Comment 7

7 years ago
VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a2) Gecko/20110710 Firefox/7.0a2 Fennec/7.0a2 

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110710 Firefox/8.0a1 Fennec/8.0a1 

Device: LG Optimus 2X
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.