665523 - Reference to *English* despite language change in the continue button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110620 Firefox/7.0a1 Fennec/7.0a1

This doesn't seem right. Each language one selects from the locale picker has an odd problem. The "Continue in *language*" button will refer to "English", either in English itself (non translated) or the selected language refers to English instead of referencing to the language selected.


ER: Selecting Français: "Continuer in Français".
AR: Selecting Français: "Continuer en Anglais".

or

ER: Selecting Italiano: "Continua in Italiano".
AR: Selecting Italiano: "Continua in Inglese".

STR:
1. Start Nightly
2. Choose a different language
3. Select Français

"Continuer en Anglais"

Or.

3. Select Deutsch

"Continue in English"

Or.

3. Select Italiano

"Continua in Inglese"

Comment 1

[Martijn Wargers (dead)]

Dupe of bug 665507?

Comment 2

[Aaron Train [:aaronmt]]

(In reply to comment #1)
> Dupe of bug 665507?

Looks like that one is reffering to the non-translation, where this one is focusing on the reference to English instead of the selected language.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This just adds a comment for localizers. Also removes an unused string.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 540533 [details]
Patch

>diff --git a/mobile/locales/en-US/chrome/localepicker.properties b/mobile/locales/en-US/chrome/localepicker.properties

>+
>+# The localized name of this locale

# LOCALIZATION NOTE (localeName): The localized name of this locale. Do not just translate the word 'English'

> name=English

I think you'll need to change the entity name so the localizers know they need to change this.

name -> localeName

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)

> I think you'll need to change the entity name so the localizers know they
> need to change this.
> 
> name -> localeName

FTR, we don't need the entity change. We'll file bugs on the locales that got it wrong

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/557b0b1ebfe6

Comment 7

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a2) Gecko/20110710 Firefox/7.0a2 Fennec/7.0a2 

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110710 Firefox/8.0a1 Fennec/8.0a1 

Device: LG Optimus 2X