If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix unused variable warning for 'shutdownObserved' in mozStorageService.cpp

RESOLVED FIXED in mozilla7

Status

()

Toolkit
Storage
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][inbound])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
storage/src/mozStorageService.cpp:296:8: warning: unused variable 'shutdownObserved'

http://mxr.mozilla.org/mozilla-central/source/storage/src/mozStorageService.cpp#296
(Assignee)

Comment 1

6 years ago
Created attachment 540478 [details] [diff] [review]
Remove unused variable
Attachment #540478 - Flags: review?(sdwilsh)
(Assignee)

Comment 2

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068
Comment on attachment 540478 [details] [diff] [review]
Remove unused variable

This was added specifically so the assertion was more clear.  I'd rather see a patch to make shutdownObserved be a DebugOnly<bool> instead.
Attachment #540478 - Flags: review?(sdwilsh) → review-
(Assignee)

Comment 4

6 years ago
Created attachment 540994 [details] [diff] [review]
DebugOnly shutdownObserved

No worries, almost did it this way to start with, oh well! :-)

Thanks!
Attachment #540478 - Attachment is obsolete: true
Attachment #540994 - Flags: review?(sdwilsh)
Comment on attachment 540994 [details] [diff] [review]
DebugOnly shutdownObserved

>+#include "mozilla/Util.h" // for DebugOnly
nit: lose the comment afterwards

r=sdwilsh
Attachment #540994 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 541325 [details] [diff] [review]
DebugOnly shutdownObserved

Only change is adjusted comment per above, carrying forwards r+.
Attachment #540994 - Attachment is obsolete: true
Attachment #541325 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/dac5cae65da3
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/dac5cae65da3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.