Closed Bug 665549 Opened 8 years ago Closed 8 years ago
Fix unused variable warning for 'shutdown
Observed' in moz Storage Service .cpp
storage/src/mozStorageService.cpp:296:8: warning: unused variable 'shutdownObserved' http://mxr.mozilla.org/mozilla-central/source/storage/src/mozStorageService.cpp#296
Comment on attachment 540478 [details] [diff] [review] Remove unused variable This was added specifically so the assertion was more clear. I'd rather see a patch to make shutdownObserved be a DebugOnly<bool> instead.
Attachment #540478 - Flags: review?(sdwilsh) → review-
No worries, almost did it this way to start with, oh well! :-) Thanks!
Comment on attachment 540994 [details] [diff] [review] DebugOnly shutdownObserved >+#include "mozilla/Util.h" // for DebugOnly nit: lose the comment afterwards r=sdwilsh
Attachment #540994 - Flags: review?(sdwilsh) → review+
Only change is adjusted comment per above, carrying forwards r+.
Whiteboard: [build_warning] → [build_warning][inbound]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.