Closed Bug 665549 Opened 8 years ago Closed 8 years ago

Fix unused variable warning for 'shutdownObserved' in mozStorageService.cpp

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning][inbound])

Attachments

(1 file, 2 obsolete files)

storage/src/mozStorageService.cpp:296:8: warning: unused variable 'shutdownObserved'

http://mxr.mozilla.org/mozilla-central/source/storage/src/mozStorageService.cpp#296
Attached patch Remove unused variable (obsolete) — Splinter Review
Attachment #540478 - Flags: review?(sdwilsh)
Comment on attachment 540478 [details] [diff] [review]
Remove unused variable

This was added specifically so the assertion was more clear.  I'd rather see a patch to make shutdownObserved be a DebugOnly<bool> instead.
Attachment #540478 - Flags: review?(sdwilsh) → review-
Attached patch DebugOnly shutdownObserved (obsolete) — Splinter Review
No worries, almost did it this way to start with, oh well! :-)

Thanks!
Attachment #540478 - Attachment is obsolete: true
Attachment #540994 - Flags: review?(sdwilsh)
Comment on attachment 540994 [details] [diff] [review]
DebugOnly shutdownObserved

>+#include "mozilla/Util.h" // for DebugOnly
nit: lose the comment afterwards

r=sdwilsh
Attachment #540994 - Flags: review?(sdwilsh) → review+
Only change is adjusted comment per above, carrying forwards r+.
Attachment #540994 - Attachment is obsolete: true
Attachment #541325 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/dac5cae65da3
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/dac5cae65da3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.