Merge nsIThreadInternal and nsIThreadInternal2

RESOLVED FIXED in mozilla7

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 1 obsolete attachment)

7.17 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Created attachment 540496 [details] [diff] [review]
Patch, v1

This interface was temporary, can be merged now.

It should be ok to keep the iid of nsIThreadInternal2, right?
Attachment #540496 - Flags: review?(benjamin)

Updated

6 years ago
Attachment #540496 - Flags: review?(benjamin) → review+
Attachment #540496 - Flags: checkin?
(In reply to comment #0)
> It should be ok to keep the iid of nsIThreadInternal2, right?

Ugh, seriously? Please don't do that.

Comment 2

6 years ago
Hrm, it's technically ABI-compatible, but really I don't see why you wouldn't bump it to a new IID (that's what I assumed the patch did).
I don't see why it's a bad thing... But I can bump it if it offends. Verdict?

Comment 4

6 years ago
bump it
Created attachment 541759 [details] [diff] [review]
Patch, v1.1

Bumped.
Assignee: nobody → bent.mozilla
Attachment #540496 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #541759 - Flags: review+
Attachment #540496 - Flags: checkin?
http://hg.mozilla.org/projects/build-system/rev/94a77bde744b
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/94a77bde744b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.