665643 - Uploading collection of active add-ons lists inactive/incompatible/deactivated and even not installed add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Add-on collector extension 2.0.1

Uploading collection of active add-ons lists inactive/incompatible/deactivated and even not installed add-ons. I see the latter ones when I edit the add-ons in the collection at the end of the list. Here they are:

moneylooklauncher
2Believe
4link.me
Easy YouTube MP3 Downloader
Convert and Paste

Example for incompatible add-on: wfx_versions

Collection:
https://addons.mozilla.org/de/firefox/collections/archaeopteryx/1066ac20-e3b5-ddc6-f26b-e34308/

I tried to reproduce with a new profile and extensions.bandwagon.debug == true, but I didn't manage to see the collection on AMO (and the extension dumps so much text to the console, that the system 'too much input' buzzer starts).

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Now a test collection is public: https://addons.mozilla.org/de/firefox/collections/archaeopteryx/58e364fe-d1a7-ff1a-4d99-8230b6/

It seems to be missing the United States English Spellchecker, the British English Dictionary and 'docked JS-console'.

Comment 2

[Brian King [:kinger]]

(In reply to comment #0)
> ... (and the extension
> dumps so much text to the console, that the system 'too much input' buzzer
> starts).

What do you mean by this?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The (continuing/lasting) beep a computer emits if something goes wrong (i.e. if you put many keys for some seconds in a input shell). This seems to be caused by the add-on dumping all the API responses with the add-ons' details to the console.

Comment 4

[David McNamara [:mackers]]

(In reply to comment #0)
> Uploading collection of active add-ons lists
> inactive/incompatible/deactivated and even not installed add-ons. I see the
> latter ones when I edit the add-ons in the collection at the end of the
> list.

This was a bug that was causing some inactive extensions to get auto-published even if the "Only publish enabled add-ons" was not checked. FF4+ only.

Fixed in r91658.

(In reply to comment #3)
> The (continuing/lasting) beep a computer emits if something goes wrong (i.e.
> if you put many keys for some seconds in a input shell). This seems to be
> caused by the add-on dumping all the API responses with the add-ons' details
> to the console.

Yes, this is not pleasant. A solution lands in r91662 with the new pref extensions.bandwagon.api_verbose. False by default, setting this to true will spit the raw API output to debug log. Other debug/verbose stuff unaffected.

Comment 5

[Brian King [:kinger]]

(In reply to comment #4)
> Yes, this is not pleasant. A solution lands in r91662 with the new pref
> extensions.bandwagon.api_verbose. False by default, setting this to true
> will spit the raw API output to debug log. Other debug/verbose stuff
> unaffected.

Dave, can you elaborate a bit more. When set to false (default), the user will not experience the beeping?

Comment 6

[David McNamara [:mackers]]

(In reply to comment #5)
> Dave, can you elaborate a bit more. When set to false (default), the user
> will not experience the beeping?

The output is significantly reduced, so chances are the beeping will be eliminated or reduced.