Malformed Multinames can throw in different locations in Verbose builds

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

1.45 KB, patch
Rick Reitmaier
: review+
Edwin Smith
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Minor, but: ifdef VERBOSE code in AbcParser will process a Multiname even if verbose mode is not enabled at Runtime. If the Multiname is malformed, it will throw here during parsing in Verbose builds, but not until much later in non-Verbose builds; we should move the parse to be done only if the verbose runtime flag is set, to minimize debugging differences between builds.
(Assignee)

Comment 1

6 years ago
Created attachment 540606 [details] [diff] [review]
Patch
Assignee: nobody → stejohns
Attachment #540606 - Flags: superreview?
Attachment #540606 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #540606 - Flags: superreview?(edwsmith)
Attachment #540606 - Flags: superreview?
Attachment #540606 - Flags: review?(rreitmai)
Attachment #540606 - Flags: review?

Updated

6 years ago
Attachment #540606 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 2

6 years ago
tr 6406:e811339f8a76
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Attachment #540606 - Flags: superreview?(edwsmith) → superreview+
You need to log in before you can comment on or make changes to this bug.