66578 - links don't appear blue in compose window

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[sujay]

using 1/25 build of netscape

1) launch netscape
2) launch composer
3) insert some text and make it a link

notice it is not a blue link. only when you browse you see the
blue link. It is a black link. This is confusing a lot of people.
Can we change it back?

all platforms.

Comment 1

[rubydoo123]

assigning to attinasi, Marc I think this is your bug, see bug 57621

Comment 2

[Marc Attinasi]

When did this start? Hmmm. I'll investigate.

Comment 3

[Marc Attinasi]

The rule that Charley added to editoroverride.css to underline links needs to 
set the color too. I propose:

:link,:visited {
text-decoration: underline;
color: blue;
}

(unless you want visited links in a different color, in which case we need a 
rule for them too.)

Comment 4

[sujay]

Come on everyone, this has been working for 6 years....different color?

blue please.

Comment 5

[Marc Attinasi]

Sujay, who is everyone here? I'm confused by your comment. I'm still wondering
when this started happening (it worked in Netscape6). I cannot remember if the
changes I had to make to composer were only on the branch just before RTM of ns6...

Anyway, here is a patch that will make links blue as well as underlined:

Index: EditorOverride.css
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/EditorOverride.css,v
retrieving revision 1.9
diff -u -r1.9 EditorOverride.css
--- EditorOverride.css  2001/01/12 22:32:44     1.9
+++ EditorOverride.css  2001/01/26 17:53:45
@@ -64,6 +64,7 @@
 */
 a:link {
   text-decoration: underline;
+  color: blue;
 }

 input[type="hidden"] {

Comment 6

[rubydoo123]

Marc, this looks good to me -- since Charley is on vacation, could you please 
make the change?

Comment 7

[sujay]

Everyone is me, Charley, you and Beth....

Links being black in Composer has caused a lot of confusion lately...
Links do show up blue in browser...not a problem there.

Links being blue in composer has been working fine for 6 years.

Comment 8

[Marc Attinasi]

Fixed: checked in editorOverride.css v. 1.10

Link are now blue again in composer!

Comment 9

[Marc Attinasi]

Note: this may need to be removed when the user's preferred link colors are 
implemented via new pref-properties (see bug 58534)

Comment 10

[Charles Manske]

Using a fixed color like "blue" doesn't seem correct to me. Don't we risk
having a bad contrast situation if user changes their browser color prefs?
Note that this is only a problem when user doesn't set any colors in a page, so
the default browser settings apply.

Comment 11

[sujay]

I never requested a fixed color of blue. I wanted
a default color of blue and the user can change it
if they desire from Prefs..

But I didn't like the black color...thats why I filed
this bug...lot of people are complaining also...

Comment 12

[Marc Attinasi]

The default color of blue should be overridable by the HTML attributes. Please
correct me if I am wrong - but in any case, this is a temporary hack until but
58534 is fixed.

Comment 13

[Charles Manske]

Thanks, Marc. With reference to bug 58534, this makes more sense now.

Comment 14

[sujay]

thanks guys....

verified in 1/30 trunk build.