665954 - JS-disabled warning message does not match mocks

Status: VERIFIED FIXED

Description

[krupa raj[:krupa]]

Created attachment 540804 [details]
screenshot

NOTE: user has JS disabled

steps to reproduce:
1. Load https://webifyme-dev.allizom.org/en-US/
2. Notice the user message about JS

expected behavior:
warning message looks like https://bugzilla.mozilla.org/attachment.cgi?id=525854

actual behavior:
JS-disabled warning message does not match mocks. See screenshot

Comment 1

[[:brez]]

What does the little X do?  If it's 'close the message' - are we sure we want to do that?

Comment 2

[William Reynolds [:williamr]]

(In reply to comment #1)
> What does the little X do?  If it's 'close the message' - are we sure we
> want to do that?

Yes, the little X is to close the message so it fades away or disappears. That behavior is okay with me.

If we think the experience is going to be truly sub-par for users with JS disabled, we can remove the little X so the user can't close the message.

Comment 3

[[:brez]]

Yea that's what I was getting at - thanks!

Comment 4

[[:brez]]

All set:

https://github.com/mozilla/webifyme/commit/74be7a7e4751c4130faf9bbb8748e0752328cf69

Comment 5

[Pratibha]

Created attachment 548427 [details]
PostFix screenshot

Verified at:
https://webifyme-dev.allizom.org/en-US/

Warning message appears as "Webify Me works best with JavaScript turned on! How do i do that?"