If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

JS-disabled warning message does not match mocks

VERIFIED FIXED in 1.0

Status

Websites
webifyme.org
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: krupa, Assigned: brez)

Tracking

unspecified

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 540804 [details]
screenshot

NOTE: user has JS disabled

steps to reproduce:
1. Load https://webifyme-dev.allizom.org/en-US/
2. Notice the user message about JS

expected behavior:
warning message looks like https://bugzilla.mozilla.org/attachment.cgi?id=525854

actual behavior:
JS-disabled warning message does not match mocks. See screenshot
(Assignee)

Updated

6 years ago
Assignee: nobody → jbresnik
(Assignee)

Comment 1

6 years ago
What does the little X do?  If it's 'close the message' - are we sure we want to do that?
(In reply to comment #1)
> What does the little X do?  If it's 'close the message' - are we sure we
> want to do that?

Yes, the little X is to close the message so it fades away or disappears. That behavior is okay with me.

If we think the experience is going to be truly sub-par for users with JS disabled, we can remove the little X so the user can't close the message.
(Assignee)

Comment 3

6 years ago
Yea that's what I was getting at - thanks!
(Assignee)

Comment 4

6 years ago
All set:

https://github.com/mozilla/webifyme/commit/74be7a7e4751c4130faf9bbb8748e0752328cf69
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Created attachment 548427 [details]
PostFix screenshot

Verified at:
https://webifyme-dev.allizom.org/en-US/

Warning message appears as "Webify Me works best with JavaScript turned on! How do i do that?"

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.